[fix] Remove shelljs's exec - it breaks on windows

Author: 3rd-Eden

index.js

@@ -1,7 +1,6 @@
 'use strict';
 
 var spawn = require('cross-spawn')
-  , shelly = require('shelljs')
   , which = require('which')
   , path = require('path')
   , util = require('util')
@@ -57,6 +56,20 @@ Object.defineProperty(Hook.prototype, 'colors', {
   }
 });
 
+/**
+ * Execute a binary.
+ *
+ * @param {String} bin Binary that needs to be executed
+ * @param {Array} args Arguments for the binary
+ * @returns {Object}
+ * @api private
+ */
+Hook.prototype.exec = function exec(bin, args) {
+  return spawn.sync(bin, args, {
+    stdio: 'pipe'
+  });
+};
+
 /**
  * Parse the package.json so we can create an normalize it's contents to
  * a usable configuration structure.
@@ -157,19 +170,14 @@ Hook.prototype.initialize = function initialize() {
   //
   if (!this.git) return this.log(this.format(Hook.log.binary, 'git'), 0);
 
-  this.root = this.shelly.exec(this.git +' rev-parse --show-toplevel', {
-    silent: true
-  });
-
-  this.status = this.shelly.exec(this.git +' status --porcelain', {
-    silent: true
-  });
+  this.root = this.exec(this.git, ['rev-parse', '--show-toplevel']);
+  this.status = this.exec(this.git, ['status', '--porcelain']);
 
   if (this.status.code) return this.log(Hook.log.status, 0);
   if (this.root.code) return this.log(Hook.log.root, 0);
 
-  this.status = this.status.output.trim();
-  this.root = this.root.output.trim();
+  this.status = this.status.stdout.toString().trim();
+  this.root = this.root.stdout.toString().trim();
 
   try {
     this.json = require(path.join(this.root, 'package.json'));
@@ -190,9 +198,7 @@ Hook.prototype.initialize = function initialize() {
   // execute.
   //
   if (this.config.template) {
-    this.shelly.exec(this.git +' config commit.template "'+ this.config.template +'"', {
-      silent: true
-    });
+    this.exec(this.git, ['config', 'commit.template', '"'+ this.config.template +'"']);
   }
 
   if (!this.config.run) return this.log(Hook.log.run, 0);
@@ -213,7 +219,7 @@ Hook.prototype.run = function runner() {
 
     //
     // There's a reason on why we're using an async `spawn` here instead of the
-    // `shelly.exec`. The sync `exec` is a hack that writes writes a file to
+    // `shelljs.exec`. The sync `exec` is a hack that writes writes a file to
     // disk and they poll with sync fs calls to see for results. The problem is
     // that the way they capture the output which us using input redirection and
     // this doesn't have the required `isAtty` information that libraries use to
@@ -239,7 +245,6 @@ Hook.prototype.run = function runner() {
  * @public
  */
 Hook.prototype.format = util.format;
-Hook.prototype.shelly = shelly;
 
 /**
  * The various of error and status messages that we can output.

install.js

@@ -5,7 +5,7 @@
 //
 var fs = require('fs')
   , path = require('path')
-  , shelly = require('shelljs')
+  , spawn = require('cross-spawn')
   , hook = path.join(__dirname, './hook')
   , root = path.resolve(__dirname, '../..')
   , exists = fs.existsSync || path.existsSync;
@@ -23,7 +23,7 @@ var git = path.resolve(root, '.git')
 //
 // Make sure that we can execute the hook without any issues before continuing.
 //
-if (shelly.exec(hook +' --dry-run', { silent: true }).code !== 0) {
+if (spawn.sync('sh', [hook, '--dry-run'], { stdio: 'ignore' }).code !== 0) {
   console.error('pre-commit:');
   console.error('pre-commit: The --dry-run of the pre-commit hook failed to execute.');
   console.error('pre-commit:');

package.json

@@ -31,7 +31,6 @@
   "license": "MIT",
   "dependencies": {
     "cross-spawn": "2.0.x",
-    "shelljs": "0.5.x",
     "which": "1.1.x"
   },
   "devDependencies": {