Skip to content

Commit 4e4e241

Browse files
committed
Fix priority sort in inline metadata
1 parent 8501981 commit 4e4e241

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

src/components/Lane/LaneMenu.tsx

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { Dispatch, StateUpdater, useContext, useEffect, useMemo, useState } from
44
import { Path } from 'src/dnd/types';
55
import { defaultSort } from 'src/helpers/util';
66
import { t } from 'src/lang/helpers';
7-
import { lableToName } from 'src/parsers/helpers/inlineMetadata';
7+
import { Priority, lableToName } from 'src/parsers/helpers/inlineMetadata';
88

99
import { anyToString } from '../Item/MetadataTable';
1010
import { KanbanContext } from '../context';
@@ -290,22 +290,28 @@ export function useSettingsMenu({ setEditState, path, lane }: UseSettingsMenuPar
290290
const desc = lane.data.sorted === k + '-asc' ? true : false;
291291

292292
children.sort((a, b) => {
293-
const valA = a.data.metadata.inlineMetadata?.find((m) => m.key === k);
294-
const valB = b.data.metadata.inlineMetadata?.find((m) => m.key === k);
293+
let valA = a.data.metadata.inlineMetadata?.find((m) => m.key === k)?.value;
294+
let valB = b.data.metadata.inlineMetadata?.find((m) => m.key === k)?.value;
295+
if (!valA && k === 'priority') {
296+
valA = Priority.None;
297+
}
298+
if (!valB && k === 'priority') {
299+
valB = Priority.None;
300+
}
295301

296302
if (valA === undefined && valB === undefined) return 0;
297303
if (valA === undefined) return 1;
298304
if (valB === undefined) return -1;
299305

300306
if (desc) {
301307
return defaultSort(
302-
anyToString(valB.value, stateManager),
303-
anyToString(valA.value, stateManager)
308+
anyToString(valB, stateManager),
309+
anyToString(valA, stateManager)
304310
);
305311
}
306312
return defaultSort(
307-
anyToString(valA.value, stateManager),
308-
anyToString(valB.value, stateManager)
313+
anyToString(valA, stateManager),
314+
anyToString(valB, stateManager)
309315
);
310316
});
311317

0 commit comments

Comments
 (0)