correctly insert image paths with ObsidianPasteImg for notes in subdirectories

[svenXY]

🚀 The feature, motivation and pitch

This is a possible solution to insert correct links with ObsidianPasteImg when using it in notes that reside in subdirectories of vaults.

Currently, when pasting an image into a note, the link that is inserted into the document only works if the note is in the topmost directory of an obsidian vault ( it will be assets_dir .. image.png).

But if the note is in a subdirectory of the vault, this will be incorrect and will not resolve properly.

For example, for a file in /home/me/vaults/work/foo/bar/mynote.md, the path relative to the vault root would have to be ../../assets/imgs/myimage.png and not assets/imgs/myimage.png

A patched img_text_func could for example look like this:

      img_text_func = function(client, path)
        path = client:vault_relative_path(path) or path
        if not path:is_absolute() then
          local p = require("obsidian.path")
          local note = client:vault_relative_path(p.buffer())
          local parents = #note:parents() - 1 -- as parents() also contains the dot dir
          path = tostring(path)
          path = ("../"):rep(parents) .. path
          path = p.new(path)
        end
        return string.format("![%s](%s)", path.name, path)
      end,

This would still support absolute paths and it would not interfere with notes in the vault top directory (leaving them unchanged). I think this could be the default implementation, otherwise maybe it could be mentioned in the help file.

[JopjeKnopje]

Thanks this is very helpful!

[neo451]

I see the issue here, but I am not sure how will it be helpful, since:

1. image render like snacks.image can not find image base on this, but neither the default impl as well lol.
2. it is not obsidian compatible, obsidian can not read this as well, it just wants a simple filename.

[neo451]

I have opened an issue #189 tracking the path issue, thank you for your great input. I will convert this to a discussion so that folks with need can see this.