refactor: Remove method canCreateSorterForLine()

It only created duplicate calls to methods which were
already been called by createSorterFromLine(), so added no new value.

Author: claremacrae

src/Query/Filter/Field.ts

@@ -142,30 +142,9 @@ export abstract class Field {
             return null;
         }
 
-        if (!this.canCreateSorterForLine(line)) {
-            return null;
-        }
-
         return this.createSorterFromLine(line);
     }
 
-    /**
-     * Returns true if the class can parse the given 'sort by' instruction line.
-     *
-     * Current implementation simply checks whether the class does support sorting,
-     * and whether the line matches this.sorterRegExp().
-     * @param line - A line from a ```tasks``` block.
-     *
-     * @see {@link createSorterFromLine}
-     */
-    public canCreateSorterForLine(line: string): boolean {
-        if (!this.supportsSorting()) {
-            return false;
-        }
-
-        return Field.lineMatchesFilter(this.sorterRegExp(), line);
-    }
-
     /**
      * Parse the line, and return either a {@link Sorter} object or null.
      *
@@ -176,8 +155,6 @@ export abstract class Field {
      * this method.
      *
      * @param line - A 'sort by' line from a ```tasks``` block.
-     *
-     * @see {@link canCreateSorterForLine}
      */
     public createSorterFromLine(line: string): Sorter | null {
         if (!this.supportsSorting()) {

tests/Query/Filter/Field.test.ts

@@ -64,7 +64,6 @@ describe('sorting - base class usability and implementation', () => {
         it('should fail to parse a "valid" line', () => {
             // expect(unsupported.parseSortLine('sort by unsupported')).toThrow(Error);
             const line = 'sort by unsupported';
-            expect(unsupported.canCreateSorterForLine(line)).toBe(false);
             expect(unsupported.createSorterFromLine(line)).toBeNull();
             const sorting = unsupported.parseSortLine(line);
             expect(sorting).toBeNull();
@@ -84,7 +83,6 @@ describe('sorting - base class usability and implementation', () => {
 
         it('should parse a valid line', () => {
             const line = 'sort by description-length';
-            expect(supported.canCreateSorterForLine(line)).toBe(true);
             expect(supported.createSorterFromLine(line)).not.toBeNull();
             const sorting = supported.parseSortLine(line);
             expect(sorting).not.toBeNull();
@@ -93,7 +91,6 @@ describe('sorting - base class usability and implementation', () => {
 
         it('should fail to parse a invalid line', () => {
             const line = 'sort by jsdajhasdfa';
-            expect(supported.canCreateSorterForLine(line)).toBe(false);
             expect(supported.createSorterFromLine(line)).toBeNull();
             const sorting = supported.parseSortLine(line);
             expect(sorting).toBeNull();

tests/Query/Filter/TagsField.test.ts

@@ -345,17 +345,6 @@ describe('Sort by tags', () => {
             expect(tagsField.supportsSorting()).toEqual(true);
         });
 
-        it('should report whether it can parse lines', () => {
-            // Valid sort by tag lines:
-            expect(tagsField.canCreateSorterForLine('sort by tag')).toBe(true);
-            expect(tagsField.canCreateSorterForLine('sort by tag 2')).toBe(true);
-            expect(tagsField.canCreateSorterForLine('sort by tag reverse')).toBe(true);
-            expect(tagsField.canCreateSorterForLine('sort by tag reverse 3')).toBe(true);
-
-            // Invalid lines:
-            expect(tagsField.canCreateSorterForLine('sort by description')).toBe(false);
-        });
-
         const tag_a = new TaskBuilder().tags(['#a']).build();
         const tag_b = new TaskBuilder().tags(['#b']).build();
         const tags_a_b = new TaskBuilder().tags(['#a', '#b']).build();
@@ -406,7 +395,6 @@ describe('Sort by tags', () => {
 
         it('should fail to parse a invalid line', () => {
             const line = 'sort by jsdajhasdfa';
-            expect(tagsField.canCreateSorterForLine(line)).toBe(false);
             expect(tagsField.createSorterFromLine(line)).toBeNull();
             const sorting = tagsField.parseSortLine(line);
             expect(sorting).toBeNull();