refactor: ! Pass TasksEvents in to IncludesSettingsUI.ts

This is to eventually allow edits to the Includes settings
to refresh Tasks search results.

Author: claremacrae

src/Config/IncludesSettingsUI.ts

@@ -1,5 +1,6 @@
 import { Setting, TextAreaComponent } from 'obsidian';
 import type TasksPlugin from '../main';
+import type { TasksEvents } from '../Obsidian/TasksEvents';
 import { IncludesSettingsService, type RenamesInProgress } from './IncludesSettingsService';
 import { type IncludesMap, type Settings, getSettings, updateSettings } from './Settings';
 
@@ -12,15 +13,18 @@ type RefreshViewCallback = () => void;
  */
 export class IncludesSettingsUI {
     private readonly plugin: TasksPlugin;
+    // @ts-expect-error: TS6133: events is declared but its value is never read.
+    private readonly events: TasksEvents;
     private readonly includesSettingsService = new IncludesSettingsService();
     private readonly nameFields: Map<string, { inputEl: HTMLInputElement; originalKey: string }> = new Map();
 
     /**
      * Creates a new instance of IncludesSettingsUI
      * @param plugin The Tasks plugin instance
      */
-    constructor(plugin: TasksPlugin) {
+    constructor(plugin: TasksPlugin, events: TasksEvents) {
         this.plugin = plugin;
+        this.events = events;
     }
 
     /**

src/Config/SettingsTab.ts

@@ -6,6 +6,7 @@ import { Status } from '../Statuses/Status';
 import type { StatusCollection } from '../Statuses/StatusCollection';
 import { createStatusRegistryReport } from '../Statuses/StatusRegistryReport';
 import { i18n } from '../i18n/i18n';
+import type { TasksEvents } from '../Obsidian/TasksEvents';
 import * as Themes from './Themes';
 import {
     type HeadingState,
@@ -34,11 +35,11 @@ export class SettingsTab extends PluginSettingTab {
     private readonly plugin: TasksPlugin;
     private readonly includesSettingsUI;
 
-    constructor({ plugin }: { plugin: TasksPlugin }) {
+    constructor({ plugin, events }: { plugin: TasksPlugin; events: TasksEvents }) {
         super(plugin.app, plugin);
 
         this.plugin = plugin;
-        this.includesSettingsUI = new IncludesSettingsUI(plugin);
+        this.includesSettingsUI = new IncludesSettingsUI(plugin, events);
     }
 
     private static createFragmentWithHTML = (html: string) =>

src/main.ts

@@ -41,7 +41,9 @@ export default class TasksPlugin extends Plugin {
         const { loggingOptions } = getSettings();
         logging.configure(loggingOptions);
 
-        this.addSettingTab(new SettingsTab({ plugin: this }));
+        const events = new TasksEvents({ obsidianEvents: this.app.workspace });
+
+        this.addSettingTab(new SettingsTab({ plugin: this, events }));
 
         initializeFile({
             metadataCache: this.app.metadataCache,
@@ -52,7 +54,6 @@ export default class TasksPlugin extends Plugin {
         // Load configured status types.
         await this.loadTaskStatuses();
 
-        const events = new TasksEvents({ obsidianEvents: this.app.workspace });
         this.cache = new Cache({
             metadataCache: this.app.metadataCache,
             vault: this.app.vault,