Skip to content

Commit 46adc4b

Browse files
WizardCMRytoEX
authored andcommitted
Check source validity before attempting to log renderer crash
1 parent 16ff0fa commit 46adc4b

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

browser-client.cpp

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,18 @@ CefRefPtr<CefResourceRequestHandler> BrowserClient::GetResourceRequestHandler(Ce
8686
void BrowserClient::OnRenderProcessTerminated(CefRefPtr<CefBrowser>, TerminationStatus, int,
8787
const CefString &error_string)
8888
{
89+
if (!valid())
90+
return;
91+
8992
std::string str_text = error_string;
90-
blog(LOG_ERROR, "[obs-browser: '%s'] Webpage has crashed unexpectedly! Reason: '%s'",
91-
obs_source_get_name(bs->source), str_text.c_str());
93+
94+
const char *sourceName = "<unknown>";
95+
96+
if (bs && bs->source)
97+
sourceName = obs_source_get_name(bs->source);
98+
99+
blog(LOG_ERROR, "[obs-browser: '%s'] Webpage has crashed unexpectedly! Reason: '%s'", sourceName,
100+
str_text.c_str());
92101
}
93102

94103
CefResourceRequestHandler::ReturnValue BrowserClient::OnBeforeResourceLoad(CefRefPtr<CefBrowser>, CefRefPtr<CefFrame>,

0 commit comments

Comments
 (0)