-Wshadow or -Wno-shadow?

[ipatix]

Operating System Info

Ubuntu 24.04

Other OS

No response

OBS Studio Version

31.0.0-rc1

OBS Studio Version (Other)

No response

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

No response

Expected Behavior

see below

Current Behavior

see below

Steps to Reproduce

see below

Anything else we should know?

I'm sorry, but it seems once again the issue template really does not apply to my case, anyway:

I discovered this while compiling my own plugin that errors are raised due to -Wshadow. Now, this may seem perfectly fine, but this led me to the place where this warning is enabled, and it leads to here:

obs-plugintemplate/cmake/linux/compilerconfig.cmake

Line 35 in e3688b7

-Wshadow

Now, what I find confusing about this is that just a few lines above -Wno-shadow is specified:

obs-plugintemplate/cmake/linux/compilerconfig.cmake

Line 28 in e3688b7

-Wno-shadow

This question goes to you, the maintainers: So is this warning supposed to be enabled or disabled?

[Fenrirthviti]

As a note, the issue template doesn't apply to you because you shouldn't be submitting issues for support questions.

I'll leave this open for someone else to comment on, but in the future, we recommend our forums or Discord for assistance.

[ipatix]

Well, at least to me this looks like a bug. However, since I don't know the intention behind the -Wshadow I cannot comment in regards to the "expected" and "actual" behavior.

[PatTheMav]

Fixed by #126.