frontend: Add utf-8 manifest and move locale setup

Utf-8 manifest allows Win32 API to use utf-8 instead of ANSI codepages. This changes the "A" versions of fucntions to work with utf-8.
Manifest also treats command line arguments as utf8. This allows for example --profile <name> to load profiles with special characters.

The locale setup routine is moved to the beginning of program to better cover io streams, without the need to reconfigure them later. The caveat is that unix will need to re-do the routine after initilizing OBSApp, because Qt overwrites the locales for unix during it's construction.

Added logging for locale info and app language to better diagnose potential errors.

Author: Dankirk

frontend/OBSApp.cpp

@@ -51,7 +51,6 @@
 
 #ifdef _WIN32
 #include <sstream>
-#include <mbctype.h>
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
 #else
@@ -871,53 +870,13 @@ std::vector<UpdateBranch> OBSApp::GetBranches()
 	return out;
 }
 
-static bool set_utf8_locale(void)
-{
-	// Use system locale with UTF-8 codepage (available from Windows 10 version 1803)
-	bool usingUTF8 = !!setlocale(LC_ALL, ".UTF-8");
-
-#ifdef _WIN32
-	usingUTF8 = usingUTF8 && (_setmbcp(CP_UTF8) == 0);
-#endif
-
-	/*
-	Fallback to minimal C locale
-	Could use "" for system defaults, but the Windows default ANSI codepages (.125x or .9xx)
-	mismatch with UTF-8 that is assumed by many parts of the codebase. "C" only covers ASCII, so no mismatches.
-	*/
-	usingUTF8 = usingUTF8 || !!setlocale(LC_ALL, "C.UTF-8");
-	if (!usingUTF8)
-		setlocale(LC_ALL, "C");
-
-	// fix float handling
-	setlocale(LC_NUMERIC, "C");
-
-	// Copy C runtime locale for C++
-	std::locale defaultLocale(setlocale(LC_ALL, nullptr));
-	std::locale::global(defaultLocale);
-
-	/*
-	system() is already the QLocale default, but just to be explicit about the intention.
-	Unlike CRT and C++ locales above, QLocale doesn't support customization of locale categories and codepages.
-	Ie. We can't enforce decimal point to be a dot and at the same time use user's preferred locale.
-	*/
-	QLocale::setDefault(QLocale::system());
-
-	blog(LOG_INFO, "Set locale to: %s", defaultLocale.name().c_str());
-
-	return usingUTF8;
-}
-
 OBSApp::OBSApp(int &argc, char **argv, profiler_name_store_t *store)
 	: QApplication(argc, argv),
 	  profilerNameStore(store),
 	  appLaunchUUID_(QUuid::createUuid())
 {
 	installNativeEventFilter(new OBS::NativeEventFilter);
 
-	if (!set_utf8_locale())
-		blog(LOG_WARNING, "Failed to set UTF-8 codepage for locales");
-
 #ifndef _WIN32
 	/* Handle SIGINT properly */
 	socketpair(AF_UNIX, SOCK_STREAM, 0, sigintFd);
@@ -1250,6 +1209,11 @@ bool OBSApp::OBSInit()
 
 	obs_set_ui_task_handler(ui_task_handler);
 
+	QString localeStr(std::locale().name().c_str());
+
+	blog(LOG_INFO, "Locale: %s", QT_TO_UTF8(localeStr.replace(";", "\n\t")));
+	blog(LOG_INFO, "App language: %s", locale.c_str());
+
 #if defined(_WIN32) || defined(__APPLE__) || defined(__linux__)
 	bool browserHWAccel = config_get_bool(appConfig, "General", "BrowserHWAccel");
 

frontend/cmake/windows/obs.manifest

@@ -11,6 +11,11 @@
             </requestedPrivileges>
         </security>
     </trustInfo>
+    <application>
+	<windowsSettings>
+	    <activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>
+        </windowsSettings>
+    </application>
     <compatibility xmlns="urn:schemas-microsoft-com:compatibility.v1">
         <application>
             <!-- Windows 10 and Windows 11 -->

frontend/obs-main.cpp

@@ -45,6 +45,7 @@
 #include <shellapi.h>
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
+#include <mbctype.h>
 #else
 #include <signal.h>
 #endif
@@ -77,6 +78,7 @@ bool opt_disable_missing_files_check = false;
 string opt_starting_collection;
 string opt_starting_profile;
 string opt_starting_scene;
+bool using_utf8 = false;
 
 bool restart = false;
 bool restart_safe = false;
@@ -408,8 +410,6 @@ static void create_log_file(fstream &logFile)
 
 	BPtr<char> path(GetAppConfigPathPtr(dst.str().c_str()));
 
-	logFile.imbue(std::locale());
-
 #ifdef _WIN32
 	BPtr<wchar_t> wpath;
 	os_utf8_to_wcs_ptr(path, 0, &wpath);
@@ -426,6 +426,41 @@ static void create_log_file(fstream &logFile)
 	}
 }
 
+static bool set_utf8_locale(void)
+{
+	// Use system locale with UTF-8 codepage (available from Windows 10 version 1803)
+	bool usingUTF8 = !!setlocale(LC_ALL, ".UTF-8");
+
+	/*
+	Fallback to minimal C locale
+	Could use "" for system defaults, but the Windows default ANSI codepages (such as .125x or .9xx)
+	mismatch with UTF-8 that is assumed by many parts of the codebase. "C" only covers ASCII, so no mismatches.
+	*/
+	usingUTF8 = usingUTF8 || !!setlocale(LC_ALL, "C.UTF-8");
+
+#ifdef _WIN32
+	usingUTF8 = usingUTF8 && (_setmbcp(CP_UTF8) == 0);
+#endif
+	if (!usingUTF8)
+		setlocale(LC_ALL, "C");
+
+	// fix float handling
+	setlocale(LC_NUMERIC, "C");
+
+	// Copy C runtime locale for C++
+	std::locale defaultLocale(setlocale(LC_ALL, nullptr));
+	std::locale::global(defaultLocale);
+
+	/*
+	system() is already the QLocale default, but just to be explicit about the intention.
+	Unlike CRT and C++ locales above, QLocale doesn't support customization of locale categories and codepages.
+	Ie. We can't enforce decimal point to be a dot and at the same time use user's preferred locale.
+	*/
+	QLocale::setDefault(QLocale::system());
+
+	return usingUTF8;
+}
+
 static auto ProfilerNameStoreRelease = [](profiler_name_store_t *store) {
 	profiler_name_store_free(store);
 };
@@ -538,6 +573,14 @@ static int run_program(fstream &logFile, int argc, char *argv[])
 	qputenv("QT_NO_SUBTRACTOPAQUESIBLINGS", "1");
 
 	OBSApp program(argc, argv, profilerNameStore.get());
+
+#if defined(Q_OS_UNIX)
+	// OBSApp (QApplication) constructor overwrote the locale for unix, so set it again
+	using_utf8 = set_utf8_locale();
+#endif
+	if (!using_utf8)
+		blog(LOG_WARNING, "Failed to set UTF-8 locale");
+
 	try {
 		QAccessible::installFactory(accessibleFactory);
 		QFontDatabase::addApplicationFont(":/fonts/OpenSans-Regular.ttf");
@@ -858,6 +901,7 @@ static bool vc_runtime_outdated()
 
 int main(int argc, char *argv[])
 {
+	using_utf8 = set_utf8_locale();
 #ifndef _WIN32
 	signal(SIGPIPE, SIG_IGN);