Test to run shellcheck on generated bash config (#20)

Signed-off-by: Stephen Sherratt <stephen@sherra.tt>

Author: gridbugs

.github/workflows/test.yml

@@ -41,3 +41,19 @@ jobs:
         sudo apt-get install -y shellcheck
     - name: "Run shellcheck on all shell scripts"
       run: shellcheck *.sh
+
+  shellcheck-on-generated-bash:
+    name: "Run shellcheck on the generated shell config for bash"
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v4
+    - name: "Install shellcheck"
+      run: |
+        sudo apt-get update
+        sudo apt-get install -y shellcheck
+    - name: "Initialize shell config with shebang so shellcheck knows it's bash"
+      run: echo '#!/usr/bin/env bash' > ~/.profile
+    - name: "Generated a shell config by installing the binary distro"
+      run: ./install.sh 3.19.1 --install-root ~/.local --update-shell-config --shell bash --shell-config ~/.profile
+    - name: "Run shellcheck on the generated shell config"
+      run: shellcheck --exclude=SC1091 ~/.profile

install.sh

@@ -438,7 +438,7 @@ main () {
         echo
     fi
 
-    dune_env_call="__dune_env $(unsubst_home "$install_root")"
+    dune_env_call="__dune_env \"$(unsubst_home "$install_root")\""
     shell_config_code() {
         echo
         echo "# BEGIN configuration from Dune installer"
@@ -447,7 +447,7 @@ main () {
         echo "#   - makes sure the dune executable is available in your \$PATH"
         echo "#   - registers shell completions for dune if completions are available for your shell"
         echo "#   - removes opam's pre-command hook because it would override Dune's shell configuration"
-        echo "source $(unsubst_home "$env_file")"
+        echo "source \"$(unsubst_home "$env_file")\""
         echo "$dune_env_call"
         echo "$remove_opam_precmd_hook # remove opam's pre-command hook"
         echo "# END configuration from Dune installer"