Skip to content

Commit 026dd74

Browse files
committed
Added some documentation about the downsides of this approach
1 parent e0a7264 commit 026dd74

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lib_eio_posix/sched.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,8 @@ let ready t _index fd revents =
166166
2. If POLLIN is set, wake the readers
167167
3. If any of POLLHUP, POLLERR, or POLLNVAL is set, wake both readers & writers.
168168
On macOS, poll() returns POLLNVAL for fds it can't poll on, such as /dev/null.
169+
This results in us blocking on block devices, which isn't a problem for /dev/null
170+
But we may want to revisit this.
169171
170172
Move any readers/writers into pending
171173
*)

0 commit comments

Comments
 (0)