Skip to content

Commit 0917e26

Browse files
committed
Update comments and stubs
1 parent 40d758b commit 0917e26

File tree

4 files changed

+9
-13
lines changed

4 files changed

+9
-13
lines changed

lib_eio/unix/fork/dune

Lines changed: 0 additions & 4 deletions
This file was deleted.

lib_eio/unix/fork_action.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99

1010
#include "fork_action.h"
1111

12+
#ifdef _WIN32
13+
#else
1214
void eio_unix_run_fork_actions(int errors, value v_actions) {
13-
#ifdef _WIN32
1415
uerror("Unsupported operation on windows", Nothing);
15-
#else
1616
int old_flags = fcntl(errors, F_GETFL, 0);
1717
fcntl(errors, F_SETFL, old_flags & ~O_NONBLOCK);
1818
while (Is_block(v_actions)) {
@@ -22,8 +22,8 @@ void eio_unix_run_fork_actions(int errors, value v_actions) {
2222
v_actions = Field(v_actions, 1);
2323
}
2424
_exit(1);
25-
#endif
2625
}
26+
#endif
2727

2828
static void try_write_all(int fd, char *buf) {
2929
int len = strlen(buf);

lib_eio_windows/eio_windows_stubs.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,22 +51,22 @@ CAMLprim value caml_eio_windows_getrandom(value v_ba, value v_off, value v_len)
5151

5252
CAMLprim value caml_eio_windows_readv(value v_fd, value v_bufs)
5353
{
54-
uerror("Readv is not supported on windows yet", Nothing);
54+
uerror("readv is not supported on windows yet", Nothing);
5555
}
5656

5757
CAMLprim value caml_eio_windows_preadv(value v_fd, value v_bufs, value v_offset)
5858
{
59-
uerror("Preadv is not supported on windows yet", Nothing);
59+
uerror("preadv is not supported on windows yet", Nothing);
6060
}
6161

6262
CAMLprim value caml_eio_windows_pwritev(value v_fd, value v_bufs, value v_offset)
6363
{
64-
uerror("Pwritev is not supported on windows yet", Nothing);
64+
uerror("pwritev is not supported on windows yet", Nothing);
6565
}
6666

6767
CAMLprim value caml_eio_windows_openat(value v_dirfd, value v_pathname, value v_flags, value v_mode)
6868
{
69-
uerror("Readv is not supported on windows yet", Nothing);
69+
uerror("openat is not supported on windows yet", Nothing);
7070
}
7171

7272
CAMLprim value caml_eio_windows_mkdirat(value v_fd, value v_path, value v_perm)
@@ -86,5 +86,5 @@ CAMLprim value caml_eio_windows_renameat(value v_old_fd, value v_old_path, value
8686

8787
CAMLprim value caml_eio_windows_spawn(value v_errors, value v_actions)
8888
{
89-
uerror("Processes are not supported on windows yet", Nothing);
89+
uerror("processes are not supported on windows yet", Nothing);
9090
}

lib_eio_windows/sched.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ let with_sched fn =
230230
let run_q = Lf_queue.create () in
231231
Lf_queue.push run_q IO;
232232
let sleep_q = Zzz.create () in
233-
(* Pipe's on Windows cannot be nonblocking through the OCaml API. *)
233+
(* Pipes on Windows cannot be nonblocking through the OCaml API. *)
234234
let eventfd_r, eventfd_w = Unix.socketpair ~cloexec:true Unix.PF_UNIX Unix.SOCK_STREAM 0 in
235235
Unix.set_nonblock eventfd_r;
236236
Unix.set_nonblock eventfd_w;

0 commit comments

Comments
 (0)