Skip to content

Commit 432e103

Browse files
authored
Merge pull request #604 from talex5/skip-fixbuf-test
eio_linux tests: skip fixed buffer test if not available
2 parents 1b2ea52 + ad0c912 commit 432e103

File tree

5 files changed

+5
-7
lines changed

5 files changed

+5
-7
lines changed

dune-project

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,14 @@
2929
(crowbar (and (>= 0.2) :with-test))
3030
(mtime (>= 2.0.0))
3131
(mdx (and (>= 2.2.0) :with-test))
32-
(alcotest (and (>= 1.4.0) :with-test))
3332
(dscheck (and (>= 0.1.0) :with-test))))
3433
(package
3534
(name eio_linux)
3635
(synopsis "Eio implementation for Linux using io-uring")
3736
(description "An Eio implementation for Linux using io-uring.")
3837
(allow_empty) ; Work-around for dune bug #6938
3938
(depends
40-
(alcotest (and (>= 1.4.0) :with-test))
39+
(alcotest (and (>= 1.7.0) :with-test))
4140
(eio (= :version))
4241
(mdx (and (>= 2.2.0) :with-test))
4342
(logs (>= 0.7.0))
@@ -62,7 +61,7 @@
6261
(depends
6362
(eio (= :version))
6463
(kcas (and (>= 0.3.0) :with-test))
65-
(alcotest (and (>= 1.4.0) :with-test))))
64+
(alcotest (and (>= 1.7.0) :with-test))))
6665
(package
6766
(name eio_main)
6867
(synopsis "Effect-based direct-style IO mainloop for OCaml")

eio.opam

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ depends: [
2222
"crowbar" {>= "0.2" & with-test}
2323
"mtime" {>= "2.0.0"}
2424
"mdx" {>= "2.2.0" & with-test}
25-
"alcotest" {>= "1.4.0" & with-test}
2625
"dscheck" {>= "0.1.0" & with-test}
2726
"odoc" {with-doc}
2827
]

eio_linux.opam

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ doc: "https://ocaml-multicore.github.io/eio/"
1010
bug-reports: "https://github.com/ocaml-multicore/eio/issues"
1111
depends: [
1212
"dune" {>= "3.9"}
13-
"alcotest" {>= "1.4.0" & with-test}
13+
"alcotest" {>= "1.7.0" & with-test}
1414
"eio" {= version}
1515
"mdx" {>= "2.2.0" & with-test}
1616
"logs" {>= "0.7.0"}

eio_windows.opam

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ depends: [
1212
"dune" {>= "3.9"}
1313
"eio" {= version}
1414
"kcas" {>= "0.3.0" & with-test}
15-
"alcotest" {>= "1.4.0" & with-test}
15+
"alcotest" {>= "1.7.0" & with-test}
1616
"odoc" {with-doc}
1717
]
1818
build: [

lib_eio_linux/tests/test.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ let test_read_exact () =
139139
~resolve:Uring.Resolve.empty
140140
"test.data"
141141
in
142-
Eio_linux.Low_level.with_chunk ~fallback:(fun () -> assert false) @@ fun chunk ->
142+
Eio_linux.Low_level.with_chunk ~fallback:Alcotest.skip @@ fun chunk ->
143143
(* Try to read one byte too far. If it's not updating the file offset, it will
144144
succeed. *)
145145
let len = String.length msg + 1 in

0 commit comments

Comments
 (0)