Dom_html: scroll{Left,Top} properties are numbers

https://drafts.csswg.org/cssom-view/#extension-to-the-element-interface
https://drafts.csswg.org/cssom-view/#extensions-to-the-window-interface

Author: vouillon

lib/js_of_ocaml/dom_html.ml

@@ -727,9 +727,9 @@ and element = object
 
   method offsetHeight : int readonly_prop
 
-  method scrollLeft : int prop
+  method scrollLeft : number_t prop
 
-  method scrollTop : int prop
+  method scrollTop : number_t prop
 
   method scrollWidth : int prop
 
@@ -2321,9 +2321,9 @@ class type window = object
 
   method blur : unit meth
 
-  method scroll : int -> int -> unit meth
+  method scroll : number_t -> number_t -> unit meth
 
-  method scrollBy : int -> int -> unit meth
+  method scrollBy : number_t -> number_t -> unit meth
 
   method sessionStorage : storage t optdef readonly_prop
 
@@ -2888,8 +2888,12 @@ let eventRelatedTarget (e : #mouseEvent t) =
 let eventAbsolutePosition' (e : #mouseEvent t) =
   let body = document##.body in
   let html = document##.documentElement in
-  ( Js.to_float e##.clientX +. Float.of_int (body##.scrollLeft + html##.scrollLeft)
-  , Js.to_float e##.clientY +. Float.of_int (body##.scrollTop + html##.scrollTop) )
+  ( Js.to_float e##.clientX
+    +. Js.to_float body##.scrollLeft
+    +. Js.to_float html##.scrollLeft
+  , Js.to_float e##.clientY
+    +. Js.to_float body##.scrollTop
+    +. Js.to_float html##.scrollTop )
 
 let eventAbsolutePosition (e : #mouseEvent t) =
   Optdef.case
@@ -2911,7 +2915,8 @@ let elementClientPosition (e : #element t) =
 let getDocumentScroll () =
   let body = document##.body in
   let html = document##.documentElement in
-  body##.scrollLeft + html##.scrollLeft, body##.scrollTop + html##.scrollTop
+  ( Js.to_float body##.scrollLeft +. Js.to_float html##.scrollLeft
+  , Js.to_float body##.scrollTop +. Js.to_float html##.scrollTop )
 
 let buttonPressed (ev : #mouseEvent Js.t) =
   Js.Optdef.case

lib/js_of_ocaml/dom_html.mli

@@ -740,9 +740,9 @@ and element = object
 
   method offsetHeight : int readonly_prop
 
-  method scrollLeft : int prop
+  method scrollLeft : number_t prop
 
-  method scrollTop : int prop
+  method scrollTop : number_t prop
 
   method scrollWidth : int prop
 
@@ -2165,9 +2165,9 @@ class type window = object
 
   method blur : unit meth
 
-  method scroll : int -> int -> unit meth
+  method scroll : number_t -> number_t -> unit meth
 
-  method scrollBy : int -> int -> unit meth
+  method scrollBy : number_t -> number_t -> unit meth
 
   method sessionStorage : storage t optdef readonly_prop
 
@@ -2597,7 +2597,7 @@ val eventAbsolutePosition : #mouseEvent t -> float * float
 val elementClientPosition : #element t -> int * int
 (** Position of an element relative to the viewport *)
 
-val getDocumentScroll : unit -> int * int
+val getDocumentScroll : unit -> float * float
 (** Viewport top/left position *)
 
 (** {2 Key event helper functions} *)

toplevel/examples/lwt_toplevel/toplevel.ml

@@ -145,7 +145,7 @@ let resize ~container ~textbox () =
   textbox##.style##.height := Js.string "auto";
   textbox##.style##.height
   := Js.string (Printf.sprintf "%dpx" (max 18 textbox##.scrollHeight));
-  container##.scrollTop := container##.scrollHeight;
+  container##.scrollTop := Js.float (float container##.scrollHeight);
   Lwt.return ()
 
 let setup_printers () =
@@ -376,7 +376,7 @@ let run _ =
     JsooTop.execute true ~pp_code:sharp_ppf ~highlight_location caml_ppf content';
     resize ~container ~textbox ()
     >>= fun () ->
-    container##.scrollTop := container##.scrollHeight;
+    container##.scrollTop := Js.float (float container##.scrollHeight);
     textbox##focus;
     Lwt.return_unit
   in