address review comments

elaborate on the new pkg_enabled function, and remove opam hint from the user error

Signed-off-by: Sudha Parimala <sudharg247@gmail.com>

Author: Sudha247

bin/install_uninstall.ml

@@ -526,12 +526,7 @@ let run
   if Pkg.Pkg_common.pkg_enabled ~workspace:source_workspace ~lock_dir_paths
   then
     User_error.raise
-      [ Pp.text "dune install is not supported with Dune package management." ]
-      ~hints:
-        [ Pp.concat
-            ~sep:Pp.space
-            [ Pp.text "Use"; User_message.command "opam"; Pp.text "instead." ]
-        ];
+      [ Pp.text "dune install is not supported with Dune package management." ];
   let* pkgs =
     match pkgs with
     | _ :: _ -> Fiber.return pkgs

bin/pkg/pkg_common.mli

@@ -82,8 +82,10 @@ end
     [lock_dir]. *)
 val pp_packages : Dune_pkg.Lock_dir.Pkg.t list -> User_message.Style.t Pp.t
 
-(** [pkg_enabled ~workspace ~lock_dir_paths] returns [true] if package management is
-    enabled. *)
+(** [pkg_enabled ~workspace ~lock_dir_paths] returns [true] if package
+      management is enabled. This is intended to be used by commands that don't
+      run the build system. For commands that do run the build system, use
+      [Dune_rules.Lock_dir.lock_dir_active]. *)
 val pkg_enabled : workspace:Workspace.t -> lock_dir_paths:Path.Source.t list -> bool
 
 (** [check_pkg_management_enabled ()] checks if package management is enabled in the

test/blackbox-tests/test-cases/pkg/install-crash-lock-context.t

@@ -32,14 +32,12 @@ Build the lockdir first
 
   $ dune install --prefix "$PWD/_install"
   Error: dune install is not supported with Dune package management.
-  Hint: Use 'opam' instead.
   [1]
 
 But `dune install` without a prefix argument crashes with an internal error.
 
   $ dune install
   Error: dune install is not supported with Dune package management.
-  Hint: Use 'opam' instead.
   [1]
 
 
@@ -60,10 +58,8 @@ crashes with the same error.
 
   $ dune install --prefix "$PWD/_install"
   Error: dune install is not supported with Dune package management.
-  Hint: Use 'opam' instead.
   [1]
 
   $ dune install
   Error: dune install is not supported with Dune package management.
-  Hint: Use 'opam' instead.
   [1]