Skip to content

Commit 9aa1fa8

Browse files
authored
test: demonstrate insufficiently commented tests (#13221)
Ideally, all tests should have comments describing what they're testing. Some old tests do not fulfill this criteria, this rule makes note of them by writing them all in a file. We should not grow this file, but shrink it over time by filling in the missing descriptions. --------- Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
1 parent 4cc2b86 commit 9aa1fa8

File tree

3 files changed

+161
-0
lines changed

3 files changed

+161
-0
lines changed

flake.nix

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@
167167
bc
168168
file
169169
jq
170+
ripgrep
170171
mercurial
171172
unzip
172173
coreutils

test/blackbox-tests/dune

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,19 @@
99
(deps setup-script.sh)
1010
(action
1111
(run %{bin:bash} -n %{deps})))
12+
13+
;; A list of tests that do not contain descriptions. This file should not not
14+
;; grow, only shrink. Once it is empty, it will become an error to introduce
15+
;; tests that do not have a description
16+
17+
(rule
18+
(target lacking-description)
19+
(deps
20+
%{bin:sort}
21+
%{bin:rg}
22+
;; CR-someday rgrinberg: we need a recursive glob for source_tree
23+
(source_tree test-cases))
24+
(mode promote)
25+
(action
26+
(system
27+
"rg --files-without-match '^\\S' --glob \"*.t\" --glob \"!*coq*\" --glob \"!*rocq*\" . | sort > %{target}")))
Lines changed: 144 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,144 @@
1+
./test-cases/actions/with-exit-codes.t
2+
./test-cases/actions/with-nested-exit-codes.t
3+
./test-cases/actions/with-stdin-from.t
4+
./test-cases/actions/with-unsupported-nested-exit-codes.t
5+
./test-cases/bad-alias-error/absolute-path.t/run.t
6+
./test-cases/bad-alias-error/outside-workspace.t/run.t
7+
./test-cases/block-strings.t/run.t
8+
./test-cases/cmdliner-dep-conf.t/run.t
9+
./test-cases/ctypes/github-5561-name-mangle.t
10+
./test-cases/custom-cross-compilation/bad-configuration.t/run.t
11+
./test-cases/custom-cross-compilation/context-not-found.t/run.t
12+
./test-cases/custom-cross-compilation/cross-compilation.t/run.t
13+
./test-cases/custom-cross-compilation/normal.t/run.t
14+
./test-cases/custom-cross-compilation/target-and-host.t/run.t
15+
./test-cases/custom-cross-compilation/topological-loop.t/run.t
16+
./test-cases/cycle-detection-symlinks-2863.t
17+
./test-cases/cyclic-dep-executable.t
18+
./test-cases/default-ocaml-flags-3-13.t
19+
./test-cases/depend-on/the-universe.t/run.t
20+
./test-cases/deprecated-fields/d-allow-approx-merlin.t
21+
./test-cases/deps-conf-vars/alias-lib-file.t
22+
./test-cases/deps-conf-vars/static.t
23+
./test-cases/dialects/bad3.t/run.t
24+
./test-cases/directory-targets/old-style/dep.t/run.t
25+
./test-cases/directory-targets/old-style/target.t/run.t
26+
./test-cases/double-echo.t/run.t
27+
./test-cases/dune-binaries.t
28+
./test-cases/dune-init/github7806.t
29+
./test-cases/dune_memory-and-the-universe.t/run.t
30+
./test-cases/enabled_if/eif-dune-describe.t
31+
./test-cases/enabled_if/eif-ocaml_version_lte.t/run.t
32+
./test-cases/env/env-cflags.t/run.t
33+
./test-cases/env/env-link_flags.t/run.t
34+
./test-cases/env/env-var-expansion/missing-default-in-blang.t/run.t
35+
./test-cases/env/env-var-expansion/nesting.t/run.t
36+
./test-cases/exclude-missing-module.t/run.t
37+
./test-cases/exec/dune-build-dir-exec-1101.t/run.t
38+
./test-cases/extensions-versioning/version-unknown.t/run.t
39+
./test-cases/extra-lang-line.t/run.t
40+
./test-cases/findlib-dynload.t/run.t
41+
./test-cases/foreign-stubs/exes-with-c.t/run.t
42+
./test-cases/foreign-stubs/fs-mode-dependent/fsmd-simple.t/run.t
43+
./test-cases/foreign-stubs/github1395.t/run.t
44+
./test-cases/foreign-stubs/github734.t/run.t
45+
./test-cases/formatting/empty-field.t
46+
./test-cases/formatting/error-field.t
47+
./test-cases/github10685.t
48+
./test-cases/github10721.t
49+
./test-cases/github20.t/run.t
50+
./test-cases/github2123.t/run.t
51+
./test-cases/github2584.t
52+
./test-cases/github2629.t
53+
./test-cases/github3180.t
54+
./test-cases/github3672.t
55+
./test-cases/github4194.t
56+
./test-cases/github5273.t
57+
./test-cases/github534.t/run.t
58+
./test-cases/github5528.t
59+
./test-cases/github568.t/run.t
60+
./test-cases/github597.t/run.t
61+
./test-cases/github761.t/run.t
62+
./test-cases/github764.t/run.t
63+
./test-cases/github784.t/run.t
64+
./test-cases/glob-deps-change.t/run.t
65+
./test-cases/ignored_subdirs/1.6.t/run.t
66+
./test-cases/ignored_subdirs/glob.t/run.t
67+
./test-cases/ignored_subdirs/logical.t/run.t
68+
./test-cases/ignored_subdirs/pre-1.6.t/run.t
69+
./test-cases/include-qualified/exe.t
70+
./test-cases/include-subdirs/error1.t/run.t
71+
./test-cases/include-subdirs/error2.t/run.t
72+
./test-cases/include-subdirs/error3.t/run.t
73+
./test-cases/inline-tests/many-backends-choose.t
74+
./test-cases/inline-tests/missing-backend.t
75+
./test-cases/inline-tests/too-many-backends.t
76+
./test-cases/installable-dup-private-libs.t/run.t
77+
./test-cases/install-dir/install-bindir.t
78+
./test-cases/install-dir/install-datadir.t
79+
./test-cases/install-dir/install-docdir.t
80+
./test-cases/install-dir/install-etcdir.t
81+
./test-cases/install-dir/install-mandir.t
82+
./test-cases/install-dry-run.t/run.t
83+
./test-cases/jsoo/env.t
84+
./test-cases/jsoo/sourcemap.t/run.t
85+
./test-cases/jsoo/without_implem.t/run.t
86+
./test-cases/lib-available.t/run.t
87+
./test-cases/melange/runtime-deps-in-target-dir.t
88+
./test-cases/menhir/cmly.t/run.t
89+
./test-cases/menhir/env.t/run.t
90+
./test-cases/merlin/dump-dot-merlin.t/run.t
91+
./test-cases/merlin/future-syntax.t
92+
./test-cases/merlin/github759.t/run.t
93+
./test-cases/merlin/include-subdirs-qualified.t
94+
./test-cases/merlin/suffix.t/run.t
95+
./test-cases/meta-gen.t/run.t
96+
./test-cases/mwe-dune-duplicate-dialect.t/duniverse/dune-configurator.2.7.1/test/dialects.t/run.t
97+
./test-cases/name-field-validation/no-name-exes-syntax-1-0.t/run.t
98+
./test-cases/null-dep.t/run.t
99+
./test-cases/ocamldep/ocamldep-multi-stanzas.t/run.t
100+
./test-cases/ocamllex/ocamllex-include-qualified.t
101+
./test-cases/ocamllex/ocamllex-include-unqualified.t
102+
./test-cases/odoc/github717-odoc-index.t/run.t
103+
./test-cases/odoc/new/github717-odoc-index.t/run.t
104+
./test-cases/package-dep.t/run.t
105+
./test-cases/pform-space-error-message.t
106+
./test-cases/ppx/9650-bytecode-rewriter.t/run.t
107+
./test-cases/private-modules/accessible-via-public.t/run.t
108+
./test-cases/private-modules/inaccessible-in-deps.t/run.t
109+
./test-cases/project-root.t/run.t
110+
./test-cases/promote/promotion-diff.t
111+
./test-cases/promote/promotion-list.t
112+
./test-cases/quoting/filename-space.t/run.t
113+
./test-cases/quoting/quote-from-context.t/run.t
114+
./test-cases/quoting/quotes-multi.t/run.t
115+
./test-cases/redirections.t/run.t
116+
./test-cases/select-field/select-2-0-rules.t
117+
./test-cases/select-field/select.t/run.t
118+
./test-cases/stanzas/dynamic-include-stanza/cycle.t
119+
./test-cases/stanzas/include-stanza/github2711.t
120+
./test-cases/stanzas/include-stanza/include-loop.t/run.t
121+
./test-cases/stanzas/tests/generated.t/run.t
122+
./test-cases/stanzas/tests/modes.t/run.t
123+
./test-cases/stanzas/tests/plural.t/run.t
124+
./test-cases/stanzas/tests/singular.t/run.t
125+
./test-cases/stdlib/stdlib-flags.t
126+
./test-cases/targets-with-vars.t/run.t
127+
./test-cases/test-build-if/version.t
128+
./test-cases/tests-locks.t/tests/a.t
129+
./test-cases/tests-locks.t/tests-no-locks/b.t
130+
./test-cases/tests-locks.t/tests-no-locks/sub/d.t
131+
./test-cases/tests-locks.t/tests/sub/b.t
132+
./test-cases/top-module/load-with-pp.t
133+
./test-cases/unreadable-src.t
134+
./test-cases/unreadable-target.t
135+
./test-cases/use-meta.t/run.t
136+
./test-cases/utop/utop-default-implementation.t/run.t
137+
./test-cases/utop/utop-simple.t/run.t
138+
./test-cases/utop/utop-stubs.t/run.t
139+
./test-cases/virtual-libraries/impl-public-modules/unwrapped.t
140+
./test-cases/virtual-libraries/module-fields.t/run.t
141+
./test-cases/windows-diff.t/run.t
142+
./test-cases/workspaces/custom-context-names.t
143+
./test-cases/wrapped-false-main-module-name.t/run.t
144+
./test-cases/wrapped-transition.t/run.t

0 commit comments

Comments
 (0)