Skip to content

Commit fe3dea2

Browse files
authored
Lib: delay applying modules (#12884)
* refactor(lib): resolve [args] only after validating name Signed-off-by: Rudi Grinberg <[email protected]>
1 parent b20ee74 commit fe3dea2

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/dune_rules/lib.ml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -721,11 +721,12 @@ module Parameterised = struct
721721

722722
and applied_name t =
723723
let open Resolve.O in
724-
let+ name = resolve_main_module_name t
725-
and+ args = applied_modules t in
726-
match name with
727-
| Some name -> { Parameterised_name.name; args }
724+
resolve_main_module_name t
725+
>>= function
728726
| None -> Code_error.raise "library missing main module name" [ "lib", to_dyn t ]
727+
| Some name ->
728+
let+ args = applied_modules t in
729+
{ Parameterised_name.name; args }
729730
;;
730731
end
731732

0 commit comments

Comments
 (0)