Skip to content

Conversation

@sabine
Copy link
Contributor

@sabine sabine commented Oct 28, 2025

Only the first commit from #12612, as it seems uncontroversial.

@Alizter
Copy link
Collaborator

Alizter commented Oct 28, 2025

You will need to sign your commit. Have a look at CONTRIBUTING.md for instructions on how to do that.

@sabine sabine force-pushed the only_move_dune_mental_model branch 3 times, most recently from dfdae32 to 2da6996 Compare October 28, 2025 15:09
@Alizter Alizter enabled auto-merge October 28, 2025 15:24
@Alizter Alizter force-pushed the only_move_dune_mental_model branch from 2da6996 to eb18701 Compare October 28, 2025 15:24
@shonfeder
Copy link
Member

shonfeder commented Oct 29, 2025

DCO is still failing with

Author: sabine, Committer: Ali Caglayan; Expected "sabine [email protected]", but got "Sabine Schmaltz [email protected]"

Fixing the git commit signoff to have the expected thing should work, IIUC.

auto-merge was automatically disabled October 29, 2025 12:53

Head branch was pushed to by a user without write access

@sabine sabine force-pushed the only_move_dune_mental_model branch from eb18701 to 3b0550c Compare October 29, 2025 12:53
@Alizter Alizter force-pushed the only_move_dune_mental_model branch from 3b0550c to cf3b325 Compare October 29, 2025 13:26
@shonfeder shonfeder enabled auto-merge (squash) October 30, 2025 19:23
@shonfeder
Copy link
Member

Thanks!

@shonfeder shonfeder merged commit 1f35103 into ocaml:main Oct 31, 2025
26 checks passed
MixiMaxiMouse pushed a commit to MixiMaxiMouse/dune that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants