Skip to content

Commit 0271918

Browse files
authored
Move Typed_holes to Merlin (#1451)
* Move typed_hole to merlin-lib * Make CI point at merlin PR
1 parent aae6986 commit 0271918

File tree

5 files changed

+4
-40
lines changed

5 files changed

+4
-40
lines changed

.github/workflows/build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949

5050
# Remove this pin once a compatible version of Merlin has been released
5151
- name: Pin dev Merlin
52-
run: opam --cli=2.1 pin --with-version=5.4-503 https://github.com/ocaml/merlin.git#main
52+
run: opam --cli=2.1 pin --with-version=5.4-503 https://github.com/liam923/merlin.git#rename-holes
5353

5454
- name: Build and install dependencies
5555
run: opam install .

ocaml-lsp-server/src/code_actions/action_construct.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ let code_action pipeline doc (params : CodeActionParams.t) =
1414
let src = Document.source doc in
1515
Compl.prefix_of_position ~short_path:false src pos
1616
in
17-
if not (Typed_hole.can_be_hole prefix)
17+
if not (Merlin_analysis.Typed_hole.can_be_hole prefix)
1818
then None
1919
else (
2020
let structures =
@@ -25,7 +25,7 @@ let code_action pipeline doc (params : CodeActionParams.t) =
2525
let pos = Mpipeline.get_lexing_pos pipeline pos in
2626
Mbrowse.enclosing pos [ Mbrowse.of_typedtree typedtree ]
2727
in
28-
if not (Typed_hole.is_a_hole structures)
28+
if not (Merlin_analysis.Typed_hole.is_a_hole structures)
2929
then None
3030
else (
3131
(* ocaml-lsp can provide [Construct] values as completion entries, so

ocaml-lsp-server/src/compl.ml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ let complete
315315
let* item = completion_item_capability in
316316
item.deprecatedSupport)
317317
in
318-
if not (Typed_hole.can_be_hole prefix)
318+
if not (Merlin_analysis.Typed_hole.can_be_hole prefix)
319319
then Complete_by_prefix.complete merlin prefix pos ~resolve ~deprecated
320320
else (
321321
let reindex_sortText completion_items =

ocaml-lsp-server/src/typed_hole.ml

Lines changed: 0 additions & 19 deletions
This file was deleted.

ocaml-lsp-server/src/typed_hole.mli

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)