[symbols] error in ranges

[correnson]

With version 1.23.0 (under VSCode) I encountered the following issue from the LSP:

[Error - 11:03:16] Request textDocument/documentSymbol failed.
Error: selectionRange must be contained in fullRange
	at Rf.validate (file:///Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:108:26806)
	at new Rf (file:///Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/workbench/api/node/extensionHostProcess.js:108:27014)
	at he0 (/Users/correnson/.vscode/extensions/ocamllabs.ocaml-platform-1.32.3/dist/vscode_ocaml_platform.bc.js:35:80046)
	at he0 (/Users/correnson/.vscode/extensions/ocamllabs.ocaml-platform-1.32.3/dist/vscode_ocaml_platform.bc.js:35:80257)
	at c00 (/Users/correnson/.vscode/extensions/ocamllabs.ocaml-platform-1.32.3/dist/vscode_ocaml_platform.bc.js:35:50811)
	at Object.t40 [as map] (/Users/correnson/.vscode/extensions/ocamllabs.ocaml-platform-1.32.3/dist/vscode_ocaml_platform.bc.js:35:50913)
	at Object.Pe0 [as asDocumentSymbols] (/Users/correnson/.vscode/extensions/ocamllabs.ocaml-platform-1.32.3/dist/vscode_ocaml_platform.bc.js:35:80003)
	at o00 (/Users/correnson/.vscode/extensions/ocamllabs.ocaml-platform-1.32.3/dist/vscode_ocaml_platform.bc.js:39:62011)
	at async JP.provideDocumentSymbols

The bug does not occurs with version 1.22.0

This is not for all modules, of course !
Although is not that easy to minimize my example to locate precisely the bug.
I'll provide additional information when available.

[voodoos]

Thanks for your report @correnson, it would be very useful to have a reproduction.

It does look related to #1529 (cc @Tim-ats-d)

@correnson if that's indeed the case, you can try to minimize by removing definitions from bottom to top in the relevant module until the errors stops showing.

[Tim-ats-d]

By investigating a bit, I have found a minimal reproduction :

let f ?x _ = x

let g childs = List.map f childs

Here is the JSON outline of the function g:

{
  "start": {
    "line": 3,
    "col": 0
  },
  "end": {
    "line": 3,
    "col": 32
  },
  "name": "g",
  "kind": "Value",
  "type": "'a list -> 'b option list",
  "children": [
    {
      "start": {
        "line": 3,
        "col": 24
      },
      "end": {
        "line": 3,
        "col":  25
      },
      "name": "arg",
      "kind": "Value",
      "type": "?x:'a -> 'b -> 'a option",
      "children": [],
      "deprecated": false,
      "selection": {
        "start": {
          "line": 0,
          "col": -1
        },
        "end": {
          "line": 0,
          "col": -1
        }
      }
    }
  ],
  "deprecated": false,
  "selection": {
    "start": {
      "line": 3,
      "col": 4
    },
    "end": {
      "line": 3,
      "col": 5
    }
  }
}

The function f is considered a child of g and it was reported with the name "arg" (?) and a dummy position.
I've tested by removing the optional argument of f and the error from the LSP disappears.