Medias: rule out error case

Author: panglesd

src/document/comment.ml

@@ -290,15 +290,10 @@ let rec nestable_block_element :
         match href with
         | `Reference (`Resolved r) -> (
             let id =
-              Odoc_model.Paths.Reference.Resolved.(identifier (r :> t))
+              Odoc_model.Paths.Reference.Resolved.Asset.(identifier (r :> t))
             in
-            match Url.from_identifier ~stop_before:false id with
-            | Ok url -> Target.Internal (Resolved url)
-            | Error exn ->
-                (* FIXME: better error message *)
-                Printf.eprintf "Id.href failed: %S\n%!"
-                  (Url.Error.to_string exn);
-                Internal Unresolved)
+            match Url.from_asset_identifier id with
+            | url -> Target.Internal (Resolved url))
         | `Reference _ -> Internal Unresolved
         | `Link href -> External href
       in

src/document/url.ml

@@ -449,6 +449,8 @@ let from_identifier ~stop_before = function
       Ok (from_path @@ Path.from_identifier p)
   | p -> Anchor.from_identifier p
 
+let from_asset_identifier p = from_path @@ Path.from_identifier p
+
 let kind id =
   match Anchor.from_identifier id with
   | Error e -> failwith (Error.to_string e)

src/document/url.mli

@@ -108,6 +108,8 @@ val from_path : Path.t -> t
 
 val from_identifier : stop_before:bool -> Identifier.t -> (t, Error.t) result
 
+val from_asset_identifier : Identifier.AssetFile.t -> t
+
 val kind : Identifier.t -> kind
 
 val render_path : Odoc_model.Paths.Path.t -> string

src/model/paths.ml

@@ -1066,6 +1066,8 @@ module Reference = struct
     end
 
     module Asset = struct
+      let identifier = function `Identifier id -> id
+
       type t = Paths_types.Resolved_reference.asset
     end
   end

src/model/paths.mli

@@ -550,6 +550,8 @@ module rec Reference : sig
 
     module Asset : sig
       type t = Paths_types.Resolved_reference.asset
+
+      val identifier : t -> Identifier.AssetFile.t
     end
 
     type t = Paths_types.Resolved_reference.any