Skip to content

Commit 73dded8

Browse files
committed
Disable hit counter in the tools memos functor
It wasn't being used and it slowed things down.
1 parent d90903a commit 73dded8

File tree

1 file changed

+3
-20
lines changed

1 file changed

+3
-20
lines changed

src/xref2/tools.ml

Lines changed: 3 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -280,51 +280,34 @@ module MakeMemo (X : MEMO) = struct
280280

281281
let cache : (X.result * int * Env.LookupTypeSet.t) M.t = M.create 10000
282282

283-
let cache_hits : int M.t = M.create 10000
284-
285283
let enabled = ref true
286284

287-
let bump_counter arg =
288-
try
289-
let new_val = M.find cache_hits arg + 1 in
290-
M.replace cache_hits arg new_val;
291-
new_val
292-
with _ ->
293-
M.add cache_hits arg 1;
294-
1
295-
296285
let memoize f env arg =
297286
if not !enabled then f env arg
298287
else
299288
let env_id = Env.id env in
300-
let n = bump_counter arg in
301289
let no_memo () =
302290
let lookups, result =
303291
Env.with_recorded_lookups env (fun env' -> f env' arg)
304292
in
305-
if n > 1 then M.add cache arg (result, env_id, lookups);
293+
M.add cache arg (result, env_id, lookups);
306294
result
307295
in
308296
match M.find_all cache arg with
309297
| [] -> no_memo ()
310298
| xs ->
311299
let rec find_fast = function
312-
| (result, env_id', _) :: _ when env_id' = env_id ->
313-
M.replace cache_hits arg (M.find cache_hits arg + 1);
314-
result
300+
| (result, env_id', _) :: _ when env_id' = env_id -> result
315301
| _ :: ys -> find_fast ys
316302
| [] -> find xs
317303
and find = function
318304
| (m, _, lookups) :: xs ->
319-
(* let b = Env.verify_lookups env lookups in *)
320305
if Env.verify_lookups env lookups then m else find xs
321306
| [] -> no_memo ()
322307
in
323308
find_fast xs
324309

325-
let clear () =
326-
M.clear cache;
327-
M.clear cache_hits
310+
let clear () = M.clear cache
328311
end
329312

330313
module LookupModuleMemo = MakeMemo (struct

0 commit comments

Comments
 (0)