Occurrences: Review comments

- Remove now unused is_internal_rec. It was added for non-persistent values, but
this has been delayed to another PR
- Remove TODO comment on Classes when building the environment: classes cannot
contain items that are contained in our current set of occurrence kinds (values,
modules, module types, ...)

Signed-off-by: Paul-Elliot <[email protected]>

Author: panglesd

src/model/paths.ml

@@ -91,36 +91,6 @@ module Identifier = struct
     | `SourceLocationInternal _ | `AssetFile _ ->
         false
 
-  let rec is_internal_rec : t -> bool =
-   fun x ->
-    is_internal x
-    ||
-    match x.iv with
-    | `Root (_, name) -> ModuleName.is_internal name
-    | `Page (_, _) -> false
-    | `LeafPage (_, _) -> false
-    | `Module (parent, _) -> is_internal_rec (parent :> t)
-    | `Parameter (parent, _) -> is_internal_rec (parent :> t)
-    | `Result x -> is_internal_rec (x :> t)
-    | `ModuleType (parent, _) -> is_internal_rec (parent :> t)
-    | `Type (parent, _) -> is_internal_rec (parent :> t)
-    | `CoreType name -> TypeName.is_internal name
-    | `Constructor (parent, _) -> is_internal (parent :> t)
-    | `Field (parent, _) -> is_internal (parent :> t)
-    | `Extension (parent, _) -> is_internal (parent :> t)
-    | `ExtensionDecl (parent, _, _) -> is_internal (parent :> t)
-    | `Exception (parent, _) -> is_internal (parent :> t)
-    | `CoreException _ -> false
-    | `Value (parent, _) -> is_internal_rec (parent :> t)
-    | `Class (parent, _) -> is_internal_rec (parent :> t)
-    | `ClassType (parent, _) -> is_internal_rec (parent :> t)
-    | `Method (parent, _) -> is_internal (parent :> t)
-    | `InstanceVariable (parent, _) -> is_internal (parent :> t)
-    | `Label (parent, _) -> is_internal (parent :> t)
-    | `SourceDir _ | `SourceLocationMod _ | `SourceLocation _ | `SourcePage _
-    | `SourceLocationInternal _ | `AssetFile _ ->
-        false
-
   let name : [< t_pv ] id -> string = fun n -> name_aux (n :> t)
 
   let rec full_name_aux : t -> string list =
@@ -701,7 +671,7 @@ module Path = struct
       | `Identifier { iv = `Module (_, m); _ }
         when Names.ModuleName.is_internal m ->
           true
-      | `Identifier i -> Identifier.is_internal_rec i
+      | `Identifier _ -> false
       | `Canonical (_, `Resolved _) -> false
       | `Canonical (x, _) ->
           (not weak_canonical_test) && inner (x : module_ :> any)

src/xref2/link.ml

@@ -481,7 +481,7 @@ module Build_env = struct
         | Comment _ -> env
         | TypExt _ -> env
         | Exception _ -> env
-        | Class _ -> env (* TODO *)
+        | Class _ -> env
         | ClassType _ -> env
         | Include i -> include_ env i
         | Open _ -> env)