Feedback from review

Author: gridbugs

packages/llama/llama.0.0.1/opam

@@ -1,19 +1,23 @@
+# This file is generated by dune, edit dune-project instead
 opam-version: "2.0"
 synopsis: "Language for Live Audio Module Arrangement"
-description: """
-Libraries for declaratively building software-defined modular synthesizers. Contains definitions of common modules for generating and processing audio waveforms such as oscillators, filters, envelope generators, sequencers and clocks. This package also includes a mechanism for playing sounds generated by synthesizer components through your speakers."""
+description:
+  "Libraries for declaratively building software-defined modular synthesizers. Contains definitions of common modules for generating and processing audio waveforms such as oscillators, filters, envelope generators, sequencers and clocks. This package also includes a mechanism for playing sounds generated by synthesizer components through your speakers."
 maintainer: ["https://github.com/gridbugs/llama/issues"]
 authors: ["Stephen Sherratt"]
 license: "MIT"
 homepage: "https://github.com/gridbugs/llama"
 bug-reports: "https://github.com/gridbugs/llama/issues"
 depends: [
   "dune" {>= "3.0"}
+  "llama_core" {= version}
   "ocaml" {>= "4.13.0" & < "5.0.0"}
   "lwt" {>= "5.4"}
+  "conf-rust-2021" {build}
+  "conf-pkg-config" {build & os = "linux"}
+  "dune-configurator" {build}
   "conf-alsa" {os = "linux"}
   "odoc" {with-doc}
-  "conf-rust-2021"
 ]
 build: [
   ["dune" "subst"] {dev}
@@ -34,7 +38,7 @@ dev-repo: "git+https://github.com/gridbugs/llama.git"
 url {
     src: "https://github.com/gridbugs/llama/releases/download/0.0.1/0.0.1_rust-deps-vendored.tar.gz"
     checksum: [
-        "sha256=367329951e605d0cf3c6555764e5eafc233aa5d70e4c93351fff160faf24c36f"
-        "sha512=93936037bd42b3119f6b0cd0a71aefdbdf7b261de9737139d98d51686526099754f1e27d5f1d7fc5aa524b0cef053a18185cebe544e208f81db7cdadcf80a468"
+        "sha256=2fb4da5b4478409118b6267f26c0c7f64f10c85d02cbb73c8ead648fc430e860"
+        "sha512=ab238268cf22fbb62d5955f849b1837bbee4a12470dde29feb0bf5237023daf01ce6d52dfad30e871948bde13b18808376d254dee90bfeeb82a8c2619d459a8f"
     ]
 }

packages/llama_core/llama_core.0.0.1/opam

@@ -0,0 +1,37 @@
+# This file is generated by dune, edit dune-project instead
+opam-version: "2.0"
+synopsis: "Core types and operations for the Llama synthesizer library"
+description:
+  "Core types and operations for Llama. This is separate from the llama package so that other packages can be written which define new synthesizer modules based on llama without needing to depend on additional packages required by llama to interact with the sound card."
+maintainer: ["https://github.com/gridbugs/llama/issues"]
+authors: ["Stephen Sherratt"]
+license: "MIT"
+homepage: "https://github.com/gridbugs/llama"
+bug-reports: "https://github.com/gridbugs/llama/issues"
+depends: [
+  "dune" {>= "3.0"}
+  "odoc" {with-doc}
+]
+build: [
+  ["dune" "subst"] {dev}
+  [
+    "dune"
+    "build"
+    "-p"
+    name
+    "-j"
+    jobs
+    "@install"
+    "@runtest" {with-test}
+    "@doc" {with-doc}
+  ]
+]
+dev-repo: "git+https://github.com/gridbugs/llama.git"
+
+url {
+    src: "https://github.com/gridbugs/llama/archive/refs/tags/0.0.1.tar.gz"
+    checksum: [
+        "sha256=4127d810390c659512a72d28e5deddda19845eb6723199a490f71db9bf9838d8"
+        "sha512=b2a6831bcaa2005d9809f0c6a3d0f0fd8f5ed645fa18c313254c67cf61415bcc0d9d9de7ff74921605d112116a5f77f182018c8a068a11ec1c6da6ecec29ba79"
+    ]
+}

packages/llama_interactive/llama_interactive.0.0.1/opam

@@ -1,3 +1,4 @@
+# This file is generated by dune, edit dune-project instead
 opam-version: "2.0"
 synopsis: "Visualization and live interaction for Llama synthesizer library"
 maintainer: ["https://github.com/gridbugs/llama/issues"]
@@ -8,7 +9,8 @@ bug-reports: "https://github.com/gridbugs/llama/issues"
 depends: [
   "dune" {>= "3.0"}
   "llama" {= version}
-  "ocamlsdl2" {>= "0.04"}
+  "tsdl" {>= "1"}
+  "conf-pkg-config" {build}
   "odoc" {with-doc}
 ]
 build: [
@@ -30,7 +32,7 @@ dev-repo: "git+https://github.com/gridbugs/llama.git"
 url {
     src: "https://github.com/gridbugs/llama/releases/download/0.0.1/0.0.1_rust-deps-vendored.tar.gz"
     checksum: [
-        "sha256=367329951e605d0cf3c6555764e5eafc233aa5d70e4c93351fff160faf24c36f"
-        "sha512=93936037bd42b3119f6b0cd0a71aefdbdf7b261de9737139d98d51686526099754f1e27d5f1d7fc5aa524b0cef053a18185cebe544e208f81db7cdadcf80a468"
+        "sha256=2fb4da5b4478409118b6267f26c0c7f64f10c85d02cbb73c8ead648fc430e860"
+        "sha512=ab238268cf22fbb62d5955f849b1837bbee4a12470dde29feb0bf5237023daf01ce6d52dfad30e871948bde13b18808376d254dee90bfeeb82a8c2619d459a8f"
     ]
 }