reftest: replace long sed with simple printf for basedir escaping

Author: rjbou

master_changes.md

@@ -119,6 +119,7 @@ users)
   * Add a test for shared fetch without checksum, and for VCS shared fetch (not handled) [#6627 @rjbou]
   * Add a test showing the error message when faced with an UTF-8 character in the package version [#6640 @kit-ty-kate]
   * Remove `getconf` filtering [#6671 @rjbou]
+  * Update/homogenise escaping `BASEDIR` using `printf` [#6671 @rjbou]
 
 ### Engine
   * Fix gcc < 14.3 bug on mingw i686 [#6624 @kit-ty-kate]

tests/reftests/download.test

@@ -165,7 +165,7 @@ Clearing cache of downloaded files
 opam-version: "2.0"
 ### <mkurl.sh>
 file="REPO/packages/foo/foo.1/opam"
-basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 url="$basedir/arch.tgz"
 echo "url {" >> "$file"
 echo "src:\"$url\"" >> "$file"
@@ -213,7 +213,7 @@ content
 opam-version: "2.0"
 ### <mkurl.sh>
 file="REPO/packages/bar/bar.1/opam"
-basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 echo "url {" >> "$file"
 echo "src:\"git+file://$basedir/bar\"" >> "$file"
 echo "}" >> "$file"

tests/reftests/fetch-package.test

@@ -36,7 +36,7 @@ install: [
 p=foo-arch.1
 arch=arch
 file="REPO/packages/${p%.*}/$p/opam"
-basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 MD5=$(openssl md5 "$arch.tgz" | cut -d' ' -f2)
 cat << EOF >> "$file"
 url {

tests/reftests/lint.test

@@ -903,7 +903,7 @@ license: "ISC"
 dev-repo: "hg+https://[email protected]"
 bug-reports: "https://nobug"
 ### <add-url.sh>
-basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 cat << EOF >> lint.opam
 url { src:"file://$basedir/an-archive" }
 EOF
@@ -924,7 +924,7 @@ license: "ISC"
 dev-repo: "hg+https://[email protected]"
 bug-reports: "https://nobug"
 ### <add-url.sh>
-basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 cat << EOF >> lint.opam
 url {
   src:"file://$basedir/an-archive.tgz"

tests/reftests/pin-legacy.test

@@ -89,7 +89,7 @@ opam-version: "2.0"
 depends: "qux"
 depexts: [ "inexistant" ]
 ### <add_pin_depends.sh>
-basedir=`echo $BASEDIR | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 echo "pin-depends: [ \"qux.dev\" \"file://$basedir/qux\" ]" >> bar/bar.opam
 ### sh add_pin_depends.sh
 ### <pin:qux/qux.opam>

tests/reftests/pin.test

@@ -61,7 +61,7 @@ EOF
   tar czf "$nv.tgz" "$nv.t"
   MD5=$(openssl md5 "$nv.tgz" | cut -d' ' -f2)
   XMD5=$(openssl md5 "$pre/files/$n.install" | cut -d' ' -f2)
-  basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\/g"`
+  basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
   cat << EOF > "$pre/opam"
 opam-version:"2.0"
 build: [ "test" "-f" "%{name}%.%{version}%.t" ]
@@ -1351,7 +1351,7 @@ src: "file://${BASEDIR}/over-epr"
 ### <pin-depends.sh>
 #!/bin/sh
 set -eu
-basedir=$(echo "$BASEDIR" | sed 's/\\/\\\\\\\\/g')
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 cat << EOF >> "$1"
 pin-depends: [
   ["$2" "file://$basedir/$3"]

tests/reftests/rebuild.test

@@ -10,7 +10,7 @@ opam-version: "2.0"
 build: [ "test" "-f" "something" ]
 ### <mkurl.sh>
 file="REPO/packages/a/a.1/opam"
-basedir=`echo $BASEDIR | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 url="$basedir/$1.tgz"
 echo "url {" >> $file
 echo "src:\"$url\"" >> $file
@@ -55,7 +55,7 @@ opam-version: "2.0"
 install: [ "test" "-f" "i-am-extra-source" ]
 ### <mkxsrc.sh>
 file="REPO/packages/b/b.1/opam"
-basedir=`echo $BASEDIR | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 xsrc="$basedir/other-sources/$1"
 echo "extra-source \"i-am-extra-source\" {" >> $file
 echo "src: \"$xsrc\"" >> $file

tests/reftests/source.test

@@ -19,7 +19,7 @@ echo "src: \"$arch.tgz\"" >> $file
 MD5=$(openssl md5 $arch.tgz | cut -d' ' -f2)
 echo "checksum: \"md5=$MD5\"" >> $file
 echo "}" >> $file
-basedir=`echo $BASEDIR | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 echo "dev-repo: \"git+file://${basedir}/pandev\"" >> $file
 ### sh mkurl.sh
 ### opam update
@@ -118,7 +118,7 @@ opam-version: "2.0"
 ### <mkurl.sh>
 p=pandore.4
 file="REPO/packages/${p%.*}/$p/opam"
-basedir=`echo $BASEDIR | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 echo "url {" >> $file
 echo "git: \"$basedir/pandev\"" >> $file
 echo "}" >> $file

tests/reftests/sources-directory-cleaning.test

@@ -18,7 +18,7 @@ echo "src: \"$arch\"" >> "$file"
 MD5=$(openssl md5 "$arch" | cut -d' ' -f2)
 echo "checksum: \"md5=$MD5\"" >> "$file"
 echo "}" >> "$file"
-basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 echo "dev-repo: \"file://${basedir}/$n\"" >> "$file"
 ### sh mkurl.sh
 ### <pkg:waste-local.1>
@@ -27,7 +27,7 @@ opam-version: "2.0"
 n=waste-local
 v=1
 file="REPO/packages/$n/$n.$v/opam"
-basedir=`echo "$BASEDIR" | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 echo "url { local: \"file://${basedir}/waste\" }" >> "$file"
 ### sh mkurl.sh
 ### opam update

tests/reftests/switch-import.test

@@ -80,7 +80,7 @@ install: ["cp" "snd.out" "%{lib}%"]
 dev-repo: "hg+https://[email protected]"
 url {
 ### <add-hash.sh>
-basedir=`echo $BASEDIR | sed "s/\\\\\\\\/\\\\\\\\\\\\\\\\/g"`
+basedir=$(printf '%s' "$BASEDIR" | sed 's/\\/\\\\/g')
 echo "src: \"git+file://${basedir}/nip#snd-head\"}}" >> twice.snd.xp
 ### sh add-hash.sh
 ### opam switch import twice.snd.xp