Remove quoted string literal highlighting from grammar (#1860)

mlantas · web-flow · commit 19ed4693b82b · 2025-06-23T05:27:16.000+09:00
* Remove quoted string literal syntax

* Update CHANGELOG
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,8 @@
 ## Unreleased
 
 - Add mlx syntax highlight (#1802)
+- Remove broken quoted string literal highlighting from grammar. Quoted strings
+  are already highlighted correctly by the language server. (#1860)
 
 ## 1.29.0
 
diff --git a/syntaxes/mlx.json b/syntaxes/mlx.json
@@ -341,27 +341,11 @@
               "match": "\\\\\""
             }
           ]
-        },
-        {
-          "comment": "quoted string literal",
-          "begin": "\\{[[:lower:]_]*\\|",
-          "end": "\\|[[:lower:]_]*\\}"
         }
       ]
     },
     "strings": {
       "patterns": [
-        {
-          "comment": "quoted string literal",
-          "name": "string.quoted.braced.ocaml",
-          "begin": "\\{(%%?[[:alpha:]_][[:word:]']*(\\.[[:alpha:]_][[:word:]']*)*[[:space:]]*)?[[:lower:]_]*\\|",
-          "end": "\\|[[:lower:]_]*\\}",
-          "beginCaptures": {
-            "1": {
-              "name": "keyword.other.extension.ocaml"
-            }
-          }
-        },
         {
           "comment": "string literal",
           "name": "string.quoted.double.ocaml",
diff --git a/syntaxes/ocaml.json b/syntaxes/ocaml.json
@@ -168,26 +168,12 @@
           "begin": "\"",
           "end": "\"",
           "patterns": [{ "match": "\\\\\\\\" }, { "match": "\\\\\"" }]
-        },
-        {
-          "comment": "quoted string literal",
-          "begin": "\\{[[:lower:]_]*\\|",
-          "end": "\\|[[:lower:]_]*\\}"
         }
       ]
     },
 
     "strings": {
       "patterns": [
-        {
-          "comment": "quoted string literal",
-          "name": "string.quoted.braced.ocaml",
-          "begin": "\\{(%%?[[:alpha:]_][[:word:]']*(\\.[[:alpha:]_][[:word:]']*)*[[:space:]]*)?[[:lower:]_]*\\|",
-          "end": "\\|[[:lower:]_]*\\}",
-          "beginCaptures": {
-            "1": { "name": "keyword.other.extension.ocaml" }
-          }
-        },
         {
           "comment": "string literal",
           "name": "string.quoted.double.ocaml",

Original file line number	Diff line number	Diff line change
`@@ -341,27 +341,11 @@`
`341`	`341`	`"match": "\\\\\""`
`342`	`342`	`}`
`343`	`343`	`]`
`344`		`- },`
`345`		`- {`
`346`		`- "comment": "quoted string literal",`
`347`		`- "begin": "\\{[[:lower:]_]*\\\|",`
`348`		`- "end": "\\\|[[:lower:]_]*\\}"`
`349`	`344`	`}`
`350`	`345`	`]`
`351`	`346`	`},`
`352`	`347`	`"strings": {`
`353`	`348`	`"patterns": [`
`354`		`- {`
`355`		`- "comment": "quoted string literal",`
`356`		`- "name": "string.quoted.braced.ocaml",`
`357`		`- "begin": "\\{(%%?[[:alpha:]_][[:word:]'](\\.[[:alpha:]_][[:word:]'])[[:space:]])?[[:lower:]_]*\\\|",`
`358`		`- "end": "\\\|[[:lower:]_]*\\}",`
`359`		`- "beginCaptures": {`
`360`		`- "1": {`
`361`		`- "name": "keyword.other.extension.ocaml"`
`362`		`- }`
`363`		`- }`
`364`		`- },`
`365`	`349`	`{`
`366`	`350`	`"comment": "string literal",`
`367`	`351`	`"name": "string.quoted.double.ocaml",`