fix connection closed problem (#900)

chris-sun-star · web-flow · commit 3c1aa3809fb2 · 2026-01-19T17:13:51.000+08:00
diff --git a/internal/sql-analyzer/collector/sql_audit.go b/internal/sql-analyzer/collector/sql_audit.go
@@ -33,7 +33,6 @@ func (c *Collector) getMaxRequestIDs() (map[string]uint64, error) {
 	if err != nil {
 		return nil, errors.Wrap(err, "Failed to get oceanbase connection")
 	}
-	defer cnx.Close()
 
 	if err := cnx.QueryList(c.Ctx, &observers, sqlconst.GetMaxRequestIDByIP, c.TenantID); err != nil {
 		return nil, errors.Wrap(err, "Failed to query max request ids")
@@ -149,7 +148,6 @@ func (c *Collector) collectSqlAuditByOBServer(svrIP string, lastRequestID uint64
 	if err != nil {
 		return nil, errors.Wrap(err, "Failed to get oceanbase connection")
 	}
-	defer cnx.Close()
 
 	if err := cnx.QueryList(c.Ctx, &results, sqlconst.GetSqlStatistics, c.TenantID, svrIP, lastRequestID); err != nil {
 		return nil, err
diff --git a/internal/sql-analyzer/collector/sql_plan.go b/internal/sql-analyzer/collector/sql_plan.go
@@ -64,7 +64,6 @@ func (w *PlanWorker) processPlan(ctx context.Context, idx int, ident *model.SqlP
 		w.collector.PlanCache.Remove(*ident) // Remove from cache
 		return
 	}
-	defer cnx.Close()
 
 	var plans []model.SqlPlan
 	if err := cnx.QueryList(ctx, &plans, sqlconst.SelectSqlPlan, ident.TenantID, ident.SvrIP, ident.SvrPort, ident.PlanID); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,6 @@ func (c *Collector) getMaxRequestIDs() (map[string]uint64, error) {`
`33`	`33`	`if err != nil {`
`34`	`34`	`return nil, errors.Wrap(err, "Failed to get oceanbase connection")`
`35`	`35`	`}`
`36`		`- defer cnx.Close()`
`37`	`36`
`38`	`37`	`if err := cnx.QueryList(c.Ctx, &observers, sqlconst.GetMaxRequestIDByIP, c.TenantID); err != nil {`
`39`	`38`	`return nil, errors.Wrap(err, "Failed to query max request ids")`
`@@ -149,7 +148,6 @@ func (c *Collector) collectSqlAuditByOBServer(svrIP string, lastRequestID uint64`
`149`	`148`	`if err != nil {`
`150`	`149`	`return nil, errors.Wrap(err, "Failed to get oceanbase connection")`
`151`	`150`	`}`
`152`		`- defer cnx.Close()`
`153`	`151`
`154`	`152`	`if err := cnx.QueryList(c.Ctx, &results, sqlconst.GetSqlStatistics, c.TenantID, svrIP, lastRequestID); err != nil {`
`155`	`153`	`return nil, err`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,6 @@ func (w PlanWorker) processPlan(ctx context.Context, idx int, ident model.SqlP`
`64`	`64`	`w.collector.PlanCache.Remove(*ident) // Remove from cache`
`65`	`65`	`return`
`66`	`66`	`}`
`67`		`- defer cnx.Close()`
`68`	`67`
`69`	`68`	`var plans []model.SqlPlan`
`70`	`69`	`if err := cnx.QueryList(ctx, &plans, sqlconst.SelectSqlPlan, ident.TenantID, ident.SvrIP, ident.SvrPort, ident.PlanID); err != nil {`