Skip to content

Commit 0e9774d

Browse files
committed
fix review
1 parent b607e42 commit 0e9774d

File tree

1 file changed

+18
-14
lines changed

1 file changed

+18
-14
lines changed

src/main/java/com/alipay/oceanbase/rpc/table/ObTableClientLSBatchOpsImpl.java

Lines changed: 18 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -230,21 +230,25 @@ public void addOperation(QueryAndMutate queryAndMutate) {
230230

231231
ObTableSingleOp singleOp = new ObTableSingleOp();
232232
ObTableQuery obTableQuery = queryAndMutate.getQuery();
233-
Delete delete = (Delete) queryAndMutate.getMutation();
234-
ObTableSingleOpQuery singleOpQuery = ObTableSingleOpQuery.getInstance(obTableQuery.getIndexName(),
235-
obTableQuery.getKeyRanges(), obTableQuery.getSelectColumns(),
236-
obTableQuery.getScanOrder(), obTableQuery.isHbaseQuery(),
237-
obTableQuery.gethTableFilter(), obTableQuery.getObKVParams(),
238-
obTableQuery.getFilterString());
233+
if (queryAndMutate.getMutation() instanceof Delete) {
234+
Delete delete = (Delete) queryAndMutate.getMutation();
235+
ObTableSingleOpQuery singleOpQuery = ObTableSingleOpQuery.getInstance(obTableQuery.getIndexName(),
236+
obTableQuery.getKeyRanges(), obTableQuery.getSelectColumns(),
237+
obTableQuery.getScanOrder(), obTableQuery.isHbaseQuery(),
238+
obTableQuery.gethTableFilter(), obTableQuery.getObKVParams(),
239+
obTableQuery.getFilterString());
239240
singleOp.setQuery(singleOpQuery);
240-
singleOp.setQuery(singleOpQuery);
241-
singleOp.setSingleOpType(ObTableOperationType.QUERY_AND_MUTATE);
242-
String[] rowKeyNames = delete.getRowKey().getColumns();
243-
Object[] rowKeyValues = delete.getRowKey().getValues();
244-
ObTableSingleOpEntity entity = ObTableSingleOpEntity.getInstance(rowKeyNames, rowKeyValues,
245-
null, null);
246-
singleOp.addEntity(entity);
247-
addOperation(singleOp);
241+
singleOp.setQuery(singleOpQuery);
242+
singleOp.setSingleOpType(ObTableOperationType.QUERY_AND_MUTATE);
243+
String[] rowKeyNames = delete.getRowKey().getColumns();
244+
Object[] rowKeyValues = delete.getRowKey().getValues();
245+
ObTableSingleOpEntity entity = ObTableSingleOpEntity.getInstance(rowKeyNames, rowKeyValues,
246+
null, null);
247+
singleOp.addEntity(entity);
248+
addOperation(singleOp);
249+
} else {
250+
throw new ObTableException("invalid operation type " + queryAndMutate.getMutation().getOperationType());
251+
}
248252
}
249253

250254
public void addOperation(Mutation mutation) throws Exception {

0 commit comments

Comments
 (0)