format project and add format check to GitHub Action

Author: whhe

.github/workflows/ci.yaml

@@ -43,7 +43,9 @@ jobs:
           distribution: 'zulu'
           cache: 'maven'
       - name: Maven Build
-        run: mvn -B clean verify -Dgpg.skip -DskipTests=true
+        run: |
+          mvn -B clean verify -Dgpg.skip -DskipTests=true
+          git diff --exit-code
 
   test-obkv-table-client-java:
     name: Test (obkv-table-client-java)

pom.xml

@@ -331,6 +331,7 @@
                     <nrOfIndentSpace>4</nrOfIndentSpace>
                     <keepBlankLines>true</keepBlankLines>
                     <sortProperties>true</sortProperties>
+                    <expandEmptyElements>false</expandEmptyElements>
                     <encoding>${project.encoding}</encoding>
                 </configuration>
             </plugin>

src/main/java/com/alipay/oceanbase/rpc/bolt/transport/ObConnectionFactory.java

@@ -40,7 +40,8 @@
 
 public class ObConnectionFactory implements ConnectionFactory {
 
-    private static final Logger         logger      = LoggerFactory.getLogger(ObConnectionFactory.class);
+    private static final Logger         logger      = LoggerFactory
+                                                        .getLogger(ObConnectionFactory.class);
 
     private static final EventLoopGroup workerGroup = NettyEventLoopUtil.newEventLoopGroup(Runtime
                                                         .getRuntime().availableProcessors() + 1,

src/main/java/com/alipay/oceanbase/rpc/bolt/transport/ObTableRemoting.java

@@ -122,7 +122,7 @@ public ObPayload invokeSync(final ObTableConnection conn, final ObPayload reques
             ObRpcResultCode resultCode = new ObRpcResultCode();
             resultCode.decode(buf);
             // If response indicates the request is routed to wrong server, we should refresh the routing meta.
-            if (!conn.getObTable().getReRouting() &&response.getHeader().isRoutingWrong()) {
+            if (!conn.getObTable().getReRouting() && response.getHeader().isRoutingWrong()) {
                 String errMessage = TraceUtil.formatTraceMessage(conn, request,
                     "routed to the wrong server: " + response.getMessage());
                 logger.warn(errMessage);
@@ -139,7 +139,8 @@ public ObPayload invokeSync(final ObTableConnection conn, final ObPayload reques
                     throw new ObTableNeedFetchAllException(errMessage, resultCode.getRcode());
                 }
             }
-            if (resultCode.getRcode() != 0 && response.getHeader().getPcode() != Pcodes.OB_TABLE_API_MOVE) {
+            if (resultCode.getRcode() != 0
+                && response.getHeader().getPcode() != Pcodes.OB_TABLE_API_MOVE) {
                 String errMessage = TraceUtil.formatTraceMessage(conn, request,
                     "routed to the wrong server: " + response.getMessage());
                 logger.warn(errMessage);

src/main/java/com/alipay/oceanbase/rpc/direct_load/protocol/v0/ObDirectLoadProtocolV0.java

@@ -69,10 +69,10 @@ public void checkIsSupported(ObDirectLoadStatement statement) throws ObDirectLoa
             logger.warn("partition names in ob version " + ObGlobal.getObVsnString(obVersion)
                         + "is not supported, minimum version required is "
                         + ObGlobal.getObVsnString(OB_VERSION_4_3_5_0));
-            throw new ObDirectLoadNotSupportedException("partition names in ob version "
-                                                    + ObGlobal.getObVsnString(obVersion)
-                                                    + " is not supported, minimum version required is "
-                                                    + ObGlobal.getObVsnString(OB_VERSION_4_3_5_0));
+            throw new ObDirectLoadNotSupportedException(
+                "partition names in ob version " + ObGlobal.getObVsnString(obVersion)
+                        + " is not supported, minimum version required is "
+                        + ObGlobal.getObVsnString(OB_VERSION_4_3_5_0));
         }
     }
 

src/main/java/com/alipay/oceanbase/rpc/location/LocationUtil.java

@@ -102,9 +102,10 @@ public Long getReplicaNum() {
      * Is partition table.
      */
     public boolean isPartitionTable() {
-        return partitionNum > 1 || (partitionInfo != null && partitionInfo.getLevel()
-                .getIndex() > ObPartitionLevel.LEVEL_ZERO.getIndex() && partitionInfo.getLevel()
-                .getIndex() < ObPartitionLevel.UNKNOWN.getIndex());
+        return partitionNum > 1
+               || (partitionInfo != null
+                   && partitionInfo.getLevel().getIndex() > ObPartitionLevel.LEVEL_ZERO.getIndex() && partitionInfo
+                   .getLevel().getIndex() < ObPartitionLevel.UNKNOWN.getIndex());
     }
 
     /*

src/main/java/com/alipay/oceanbase/rpc/location/model/TableEntry.java

@@ -121,14 +121,14 @@ public void addTabletOperation(ObTableTabletOp tabletOp) {
     public void setLsOperation(ObTableLSOperation lsOperation) {
         this.lsOperation = lsOperation;
     }
-    
+
     /*
      * Get entity type.
      */
     public ObTableEntityType getEntityType() {
         return entityType;
     }
-    
+
     /*
      * Set entity type.
      */

src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/ObTableLSOpRequest.java

@@ -82,15 +82,17 @@ public void init() throws Exception {
                 } catch (Exception e) {
                     if (e instanceof ObTableNeedFetchAllException) {
                         setExpectant(refreshPartition(this.asyncRequest.getObTableQueryRequest()
-                            .getTableQuery(), client.getPhyTableNameFromTableGroup(entityType, tableName)));
+                            .getTableQuery(), client.getPhyTableNameFromTableGroup(entityType,
+                            tableName)));
                         it = expectant.entrySet().iterator();
                         retryTimes++;
                         if (retryTimes > maxRetries) {
                             RUNTIME.error("Fail to get refresh table entry response after {}",
                                 retryTimes);
                             throw new ObTableRetryExhaustedException(
                                 "Fail to get refresh table entry response after " + retryTimes
-                                + "errorCode:" + ((ObTableNeedFetchAllException) e).getErrorCode());
+                                        + "errorCode:"
+                                        + ((ObTableNeedFetchAllException) e).getErrorCode());
 
                         }
                     } else {
@@ -188,7 +190,7 @@ protected Map<Long, ObPair<Long, ObTableParam>> refreshPartition(ObTableQuery ta
     public void renewLease() throws Exception {
         if (!isEnd() && !expectant.isEmpty()) {
             Iterator<Map.Entry<Long, ObPair<Long, ObTableParam>>> it = expectant.entrySet()
-                    .iterator();
+                .iterator();
             Map.Entry<Long, ObPair<Long, ObTableParam>> lastEntry = it.next();
             ObPair<Long, ObTableParam> partIdWithObTable = lastEntry.getValue();
             // try access new partition, async will not remove useless expectant
@@ -230,7 +232,8 @@ public boolean next() throws Exception {
                     referToLastStreamResult(lastEntry.getValue());
                 } catch (Exception e) {
                     if (e instanceof ObTableNeedFetchAllException) {
-                        String realTableName = client.getPhyTableNameFromTableGroup(entityType, tableName);
+                        String realTableName = client.getPhyTableNameFromTableGroup(entityType,
+                            tableName);
                         this.asyncRequest.getObTableQueryRequest().getTableQuery()
                             .adjustStartKey(currentStartKey);
                         setExpectant(refreshPartition(this.asyncRequest.getObTableQueryRequest()
@@ -262,7 +265,8 @@ public boolean next() throws Exception {
                     referToNewPartition(entry.getValue());
                 } catch (Exception e) {
                     if (e instanceof ObTableNeedFetchAllException) {
-                        String realTableName = client.getPhyTableNameFromTableGroup(entityType, tableName);
+                        String realTableName = client.getPhyTableNameFromTableGroup(entityType,
+                            tableName);
                         this.asyncRequest.getObTableQueryRequest().getTableQuery()
                             .adjustStartKey(currentStartKey);
                         setExpectant(refreshPartition(this.asyncRequest.getObTableQueryRequest()

src/main/java/com/alipay/oceanbase/rpc/stream/ObTableClientQueryAsyncStreamResult.java

@@ -23,11 +23,11 @@
 import static com.alipay.oceanbase.rpc.util.Serialization.encodeObUniVersionHeader;
 
 public class ObHBaseParams extends ObKVParamsBase {
-    int                      caching                    = -1;    // limit the number of for each rpc call
-    int                      callTimeout                = -1;    // scannerLeasePeriodTimeout in hbase, client rpc timeout
-    boolean                  allowPartialResults        = true;  // whether allow partial row return or not
-    boolean                  isCacheBlock               = false; // whether enable server block cache and row cache or not
-    boolean                  checkExistenceOnly         = false; // check the existence only
+    int                      caching                    = -1;     // limit the number of for each rpc call
+    int                      callTimeout                = -1;     // scannerLeasePeriodTimeout in hbase, client rpc timeout
+    boolean                  allowPartialResults        = true;   // whether allow partial row return or not
+    boolean                  isCacheBlock               = false;  // whether enable server block cache and row cache or not
+    boolean                  checkExistenceOnly         = false;  // check the existence only
     String                   hbaseVersion               = "1.3.6";
 
     private static final int FLAG_ALLOW_PARTIAL_RESULTS = 1 << 0;
@@ -120,7 +120,7 @@ public byte[] encode() {
         System.arraycopy(booleansToByteArray(), 0, bytes, idx, 1);
         idx += 1;
         System.arraycopy(Serialization.encodeVString(hbaseVersion), 0, bytes, idx,
-                Serialization.getNeedBytes(hbaseVersion));
+            Serialization.getNeedBytes(hbaseVersion));
         idx += Serialization.getNeedBytes(hbaseVersion);
 
         return bytes;
@@ -150,8 +150,8 @@ public String toString() {
         return "ObParams: {\n pType = " + pType + ", \n caching = " + caching
                + ", \n callTimeout = " + callTimeout + ", \n allowPartialResult = "
                + allowPartialResults + ", \n isCacheBlock = " + isCacheBlock
-               + ", \n checkExistenceOnly = " + checkExistenceOnly
-               + ", \n hbaseVersion = " + hbaseVersion  + "\n}\n";
+               + ", \n checkExistenceOnly = " + checkExistenceOnly + ", \n hbaseVersion = "
+               + hbaseVersion + "\n}\n";
     }
 
 }