Remove unnecessary comments and format code

Author: maochongxin

src/main/java/com/alipay/oceanbase/rpc/ObTableClient.java

@@ -1337,7 +1337,7 @@ public TableEntry refreshTableLocationByTabletId(TableEntry tableEntry, String t
 
             long lastRefreshTime = tableEntry.getPartitionEntry().getPartitionInfo(tabletId).getLastUpdateTime();
             long currentTime = System.currentTimeMillis();
-            if (currentTime - lastRefreshTime < 200) {
+            if (currentTime - lastRefreshTime < tableEntryRefreshIntervalBase) {
                 return tableEntry;
             }
 
@@ -2027,7 +2027,7 @@ public List<ObPair<Long, ObTableParam>> getTables(String tableName, ObTableQuery
         // obTableParams -> List<Pair<logicId, obTableParams>>
         List<ObPair<Long, ObTableParam>> obTableParams = new ArrayList<ObPair<Long, ObTableParam>>();
         for (ObPair<Long, ReplicaLocation> partIdWithReplica : partIdWithReplicaList) {
-            long tabletId = partIdWithReplica.getLeft();
+            long partId = partIdWithReplica.getLeft();
             ReplicaLocation replica = partIdWithReplica.getRight();
             ObServerAddr addr = replica.getAddr();
             ObTable obTable = tableRoster.get(addr);
@@ -2039,7 +2039,7 @@ public List<ObPair<Long, ObTableParam>> getTables(String tableName, ObTableQuery
                         addr, addrExpired);
                 syncRefreshMetadata();
                 tableEntry = getOrRefreshTableEntry(tableName, true, waitForRefresh, false);
-                replica = getPartitionLocation(tableEntry, tabletId, route);
+                replica = getPartitionLocation(tableEntry, partId, route);
                 addr = replica.getAddr();
                 obTable = tableRoster.get(addr);
             }
@@ -2050,9 +2050,14 @@ public List<ObPair<Long, ObTableParam>> getTables(String tableName, ObTableQuery
             }
 
             ObTableParam param = new ObTableParam(obTable);
+            if (ObGlobal.obVsnMajor() >= 4) {
+                long partIdx = tableEntry.getPartIdx(partId);
+                partId = tableEntry.isPartitionTable() ? tableEntry.getPartitionInfo()
+                        .getPartTabletIdMap().get(partIdx) : partId;
+            }
             param.setTableId(tableEntry.getTableId());
             // real partition(tablet) id
-            param.setPartitionId(tabletId);
+            param.setPartitionId(partId);
 
             addr.recordAccess();
             obTableParams.add(new ObPair<Long, ObTableParam>(partIdWithReplica.getLeft(), param));

src/main/java/com/alipay/oceanbase/rpc/bolt/transport/ObTableRemoting.java

@@ -122,7 +122,7 @@ public ObPayload invokeSync(final ObTableConnection conn, final ObPayload reques
             ObRpcResultCode resultCode = new ObRpcResultCode();
             resultCode.decode(buf);
             // If response indicates the request is routed to wrong server, we should refresh the routing meta.
-            if (!conn.getObTable().getReRouting() &&response.getHeader().isRoutingWrong()) {
+            if (!conn.getObTable().getReRouting() && response.getHeader().isRoutingWrong()) {
                 String errMessage = TraceUtil.formatTraceMessage(conn, request,
                     "routed to the wrong server: " + response.getMessage());
                 logger.warn(errMessage);

src/main/java/com/alipay/oceanbase/rpc/location/model/TableEntry.java

@@ -55,25 +55,8 @@ public class TableEntry {
     private TableEntryKey                    tableEntryKey         = null;
     private volatile ObPartitionEntry        partitionEntry        = null;
 
-    // tablet id ==> refresh time
-    private final ConcurrentHashMap<Long, Long> refreshTimeMap = new ConcurrentHashMap<>();
     public ConcurrentHashMap<Long, Lock> refreshLockMap = new ConcurrentHashMap<>();
 
-    public long getTabletLocationLastRefreshTimeMills(Long tabletId) {
-        return refreshTimeMap.getOrDefault(tabletId, 0L);
-    }
-    public void setTableLocationLastRefreshTimeMills(Long tabletId, Long lastRefreshTime) {
-        refreshTimeMap.put(tabletId, lastRefreshTime);
-    }
-    
-    public Lock getRefreshLock(Long tabletId) {
-        return refreshLockMap.get(tabletId);
-    }
-    public void setRefreshLock(Long tabletId, Lock refreshLock) {
-        refreshLockMap.put(tabletId, refreshLock);
-    }
-    
-    
     /*
      * Is valid.
      */

src/main/java/com/alipay/oceanbase/rpc/location/model/partition/ObPartitionEntry.java

@@ -31,9 +31,6 @@ public class ObPartitionEntry {
     private Map<Long, Long> tabletLsIdMap = new HashMap<>();
 
     // tabelt id -> (PartitionLocation, LsId)
-    // tablet id 作为索引管理PartitionInfo 其中包含了 PartitionLocation 和LSID
-    // 外部会通过tablet id并发的读写ObPartitionLocationInfo
-    // 写的场景就是更新，读的场景是正常的请求执行，需要保证读写的安全性，更新的时候一方面是保证线程安全，另一方面还需要保证不能频繁更新
     private ConcurrentHashMap<Long, ObPartitionLocationInfo> partitionInfos = new ConcurrentHashMap<>();
 
 

src/main/java/com/alipay/oceanbase/rpc/protocol/payload/impl/execute/query/AbstractQueryStreamResult.java

@@ -51,7 +51,6 @@ public abstract class AbstractQueryStreamResult extends AbstractPayload implemen
     protected volatile boolean                                                 closed              = false;
     protected volatile List<ObObj>                                             row                 = null;
     protected volatile int                                                     rowIndex            = -1;
-    // 调整它的startKey
     protected ObTableQuery                                                     tableQuery;
     protected long                                                             operationTimeout    = -1;
     protected String                                                           tableName;