Skip to content

Commit fed27bd

Browse files
authored
fix and opt for some exceptions process (#262)
* add log info for ObTableConnectionUnWritableException * remove assert * remove assert
1 parent 3adb64d commit fed27bd

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/main/java/com/alipay/oceanbase/rpc/bolt/transport/ObTableConnection.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ public void reConnectAndLogin(String msg) throws ObTableException {
259259
} catch (ObTableServerConnectException ex) {
260260
throw ex;
261261
} catch (Exception ex) {
262-
throw new ObTableConnectionStatusException("check status failed", ex);
262+
throw new ObTableConnectionStatusException("check status failed, cause: " + ex.getMessage(), ex);
263263
}
264264
}
265265

src/main/java/com/alipay/oceanbase/rpc/table/ObTable.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ public ObPayload execute(final ObPayload request) throws RemotingException,
391391
} catch (ObTableServerConnectException ex) {
392392
throw ex;
393393
} catch (Exception ex) {
394-
throw new ObTableConnectionStatusException("check status failed", ex);
394+
throw new ObTableConnectionStatusException("check status failed, cause: " + ex.getMessage(), ex);
395395
}
396396
return executeWithReconnect(connection, request);
397397
}
@@ -455,7 +455,7 @@ public ObPayload executeWithConnection(final ObPayload request,
455455
} catch (ObTableServerConnectException ex) {
456456
throw ex;
457457
} catch (Exception ex) {
458-
throw new ObTableConnectionStatusException("check status failed", ex);
458+
throw new ObTableConnectionStatusException("check status failed, cause: " + ex.getMessage(), ex);
459459
}
460460
return executeWithReconnect(connection, request);
461461
}

src/main/java/com/alipay/oceanbase/rpc/table/ObTableClientBatchOpsImpl.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -398,17 +398,14 @@ public void partitionExecute(ObTableOperationResult[] results,
398398
} catch (Exception ex) {
399399
if (obTableClient.isOdpMode()) {
400400
if ((tryTimes - 1) < obTableClient.getRuntimeRetryTimes()) {
401-
assert ex instanceof ObTableException;
402401
logger
403402
.warn(
404-
"batch ops execute while meet Exception, tablename:{}, errorCode: {} , errorMsg: {}, try times {}",
405-
tableName, ((ObTableException) ex).getErrorCode(), ex.getMessage(),
403+
"batch ops execute while meet Exception, tablename:{}, errorMsg: {}, try times {}",
404+
tableName, ex.getMessage(),
406405
tryTimes);
407406
if (ex instanceof ObTablePartitionChangeException
408407
&& ((ObTablePartitionChangeException) ex).getErrorCode() == ResultCodes.OB_ERR_KV_ROUTE_ENTRY_EXPIRE.errorCode) {
409408
odpNeedRenew = true;
410-
} else {
411-
throw ex;
412409
}
413410
} else {
414411
RUNTIME.error("retry fail when normal batch executing", ex);

0 commit comments

Comments
 (0)