fix(sync-table): the default value is considered missing when it is whitespace (#4247)

* add log

* fix

* fix

* fix

Author: guowl3

server/odc-common/src/main/java/com/oceanbase/odc/common/util/StringUtils.java

@@ -199,6 +199,22 @@ public static void quoteColumnDefaultValuesForMySQL(DBTable table) {
         }
     }
 
+    // do not ignore default value of empty string
+    public static void quoteColumnDefaultValuesForMySQLCopied(DBTable table) {
+        if (!CollectionUtils.isEmpty(table.getColumns())) {
+            table.getColumns().forEach(column -> {
+                String defaultValue = column.getDefaultValue();
+                if (StringUtils.isNotEmpty(defaultValue)) {
+                    if (!isDefaultValueBuiltInFunction(column) && !DataTypeUtil.isBitType(column.getTypeName())) {
+                        column.setDefaultValue("'".concat(defaultValue.replace("'", "''")).concat("'"));
+                    }
+                } else if (!column.getNullable()) {
+                    column.setDefaultValue("''");
+                }
+            });
+        }
+    }
+
     /**
      * Check whether the data_default contain built in function. Any of the synonyms for
      * CURRENT_TIMESTAMP have the same meaning as CURRENT_TIMESTAMP. These are CURRENT_TIMESTAMP(),

server/odc-service/src/main/java/com/oceanbase/odc/service/dlm/DLMTableStructureSynchronizer.java

@@ -30,6 +30,7 @@
 import javax.sql.DataSource;
 
 import com.oceanbase.odc.common.util.JdbcOperationsUtil;
+import com.oceanbase.odc.common.util.StringUtils;
 import com.oceanbase.odc.core.shared.constant.ConnectType;
 import com.oceanbase.odc.core.shared.constant.DialectType;
 import com.oceanbase.odc.service.connection.model.ConnectionConfig;
@@ -94,6 +95,8 @@ public static void sync(ConnectionConfig srcConfig, ConnectionConfig tgtConfig,
                     Collections.singletonList(srcTableName)).get(srcTableName);
             DBTable tgtTable = tgtAccessor.getTables(tgtConfig.getDefaultSchema(),
                     Collections.singletonList(tgtTableName)).get(tgtTableName);
+            StringUtils.quoteColumnDefaultValuesForMySQLCopied(srcTable);
+            StringUtils.quoteColumnDefaultValuesForMySQLCopied(tgtTable);
             DBTableStructureComparator comparator = new DBTableStructureComparator(tgtTableEditor,
                     tgtConfig.getType().getDialectType(), srcConfig.getDefaultSchema(), tgtConfig.getDefaultSchema());
             List<String> changeSqlScript = new LinkedList<>();
@@ -155,8 +158,10 @@ public static void createTempTable(DataSourceInfo sourceInfo, String srcTableNam
             if (!tables.containsKey(tempTableName)) {
                 DBTable srcTable = tables.get(srcTableName);
                 srcTable.setName(tempTableName);
+                StringUtils.quoteColumnDefaultValuesForMySQLCopied(srcTable);
                 DBTableEditor tableEditor = getDBTableEditor(srcConfig.getType(), srcDbVersion);
                 String createTableDdl = tableEditor.generateCreateObjectDDL(srcTable);
+                log.info("Start to create temporary table,ddl={}", createTableDdl);
                 try (Connection conn = sourceDs.getConnection();
                         PreparedStatement ps = conn.prepareStatement(createTableDdl)) {
                     ps.execute();