Skip to content

Commit 6612032

Browse files
authored
Merge pull request #365 from abkfenris/fix-github-links
Fixing Github links
2 parents ca96668 + 2ac26d6 commit 6612032

File tree

1 file changed

+9
-11
lines changed

1 file changed

+9
-11
lines changed

_ext/ohw_team.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,14 @@ def run(self):
8686
)
8787
)
8888
body = nodes.container(is_div=True, classes=["card-body"])
89-
name = nodes.paragraph(text=member["name"], classes=["h5"])
89+
name = nodes.paragraph(text=member["name"] + " ", classes=["h5"])
9090

9191
# Add Github icon if github user account is provided
9292
if "github_user" in member and member["github_user"] is not None:
93-
target = directives.uri("https://github.com/" + member["github_user"])
94-
link = nodes.reference(
95-
"", refuri=target, text="", classes=["fab", "fa-github", "ml-1"]
96-
)
97-
link.append(nodes.inline(text=""))
93+
target = "https://github.com/" + member["github_user"]
94+
icon = nodes.inline(text="", classes=["fab", "fa-github", "ml-1"])
95+
link = nodes.reference("", refuri=target)
96+
link.append(icon)
9897
name.append(link)
9998

10099
# If emails are avaliable and email_icon is enabled, then add a email icon
@@ -103,11 +102,10 @@ def run(self):
103102
and "email" in member
104103
and member["email"] is not None
105104
):
106-
target = directives.uri("mailto:" + member["email"])
107-
link = nodes.reference(
108-
"", refuri=target, text="", classes=["fas", "fa-envelope", "ml-1"]
109-
)
110-
link.append(nodes.inline(text=""))
105+
target = "mailto:" + member["email"]
106+
icon = nodes.inline(text="", classes=["fas", "fa-envelope", "ml-1"])
107+
link = nodes.reference("", refuri=target)
108+
link.append(icon)
111109
name.append(link)
112110

113111
body.extend(

0 commit comments

Comments
 (0)