Skip to content

Commit 5af143a

Browse files
authored
Merge pull request #3 from oclero/dev
v1.3.2
2 parents 35a6b06 + a285762 commit 5af143a

File tree

8 files changed

+34
-32
lines changed

8 files changed

+34
-32
lines changed

.github/workflows/linux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Install Qt
2222
uses: jurplel/install-qt-action@v4
2323
with:
24-
version: "6.8.2"
24+
version: "6.10.1"
2525
host: linux
2626
target: desktop
2727
arch: linux_gcc_64

.github/workflows/macos.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
- name: Install Qt
2525
uses: jurplel/install-qt-action@v4
2626
with:
27-
version: "6.8.2"
27+
version: "6.10.1"
2828
host: mac
2929
target: desktop
3030
arch: clang_64

.github/workflows/windows.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121
- name: Install Qt
2222
uses: jurplel/install-qt-action@v4
2323
with:
24-
version: "6.8.2"
24+
version: "6.10.1"
2525
host: windows
2626
target: desktop
2727
arch: win64_msvc2022_64

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## v1.3.2
4+
5+
- Update CMake configuration to use GNUInstallDirs for standard installation paths.
6+
- Update export and install commands to use project namespace.
7+
- Fix compatibility with Qt6 < 6.4.
8+
39
## v1.3.1
410

511
- Remove `#pragma region` and `#pragma endregion` comments.

CMakeLists.txt

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ set(CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")
1010
# Set project information.
1111
project("QtAppInstanceManager"
1212
LANGUAGES CXX
13-
VERSION 1.3.1.0
13+
VERSION 1.3.2.0
1414
DESCRIPTION "A tool to communicate between the instances of your Qt application."
1515
HOMEPAGE_URL "https://github.com/oclero/QtAppInstanceManager"
1616
)
@@ -26,9 +26,20 @@ if(NOT CMAKE_OSX_DEPLOYMENT_TARGET)
2626
endif()
2727
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_SOURCE_DIR}/cmake")
2828

29+
# Include GNUInstallDirs for standard installation paths.
30+
include(GNUInstallDirs)
31+
2932
# Find Qt.
3033
find_package(Qt6 REQUIRED COMPONENTS Core Network)
31-
qt_standard_project_setup()
34+
35+
# qt_standard_project_setup() is only available in Qt >= 6.3.
36+
if(COMMAND qt_standard_project_setup)
37+
qt_standard_project_setup()
38+
else()
39+
set(CMAKE_AUTOMOC ON)
40+
set(CMAKE_AUTOUIC ON)
41+
set(CMAKE_AUTORCC ON)
42+
endif()
3243

3344
# The library.
3445
add_subdirectory(src)

CMakePresets.json

Lines changed: 9 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,7 @@
6363
"displayName": "macOS",
6464
"configurePreset": "macos",
6565
"description": "Release build for macOS",
66-
"targets": [
67-
"QtAppInstanceManager"
68-
],
66+
"targets": ["QtAppInstanceManager"],
6967
"configuration": "Release",
7068
"condition": {
7169
"type": "equals",
@@ -78,9 +76,7 @@
7876
"displayName": "Tests for macOS",
7977
"configurePreset": "macos",
8078
"description": "Tests release build for macOS",
81-
"targets": [
82-
"QtAppInstanceManagerTests"
83-
],
79+
"targets": ["QtAppInstanceManagerTests"],
8480
"configuration": "Release",
8581
"condition": {
8682
"type": "equals",
@@ -93,9 +89,7 @@
9389
"displayName": "Windows",
9490
"configurePreset": "windows",
9591
"description": "Release build for Windows",
96-
"targets": [
97-
"QtAppInstanceManager"
98-
],
92+
"targets": ["QtAppInstanceManager"],
9993
"configuration": "Release",
10094
"condition": {
10195
"type": "equals",
@@ -108,9 +102,7 @@
108102
"displayName": "Tests for Windows",
109103
"configurePreset": "windows",
110104
"description": "Tests release build for Windows",
111-
"targets": [
112-
"QtAppInstanceManagerTests"
113-
],
105+
"targets": ["QtAppInstanceManagerTests"],
114106
"configuration": "Release",
115107
"condition": {
116108
"type": "equals",
@@ -123,9 +115,7 @@
123115
"displayName": "Linux",
124116
"configurePreset": "linux",
125117
"description": "Release build for Linux",
126-
"targets": [
127-
"QtAppInstanceManager"
128-
],
118+
"targets": ["QtAppInstanceManager"],
129119
"configuration": "Release",
130120
"condition": {
131121
"type": "equals",
@@ -138,9 +128,7 @@
138128
"displayName": "Tests for Linux",
139129
"configurePreset": "linux",
140130
"description": "Tests release build for Linux",
141-
"targets": [
142-
"QtAppInstanceManagerTests"
143-
],
131+
"targets": ["QtAppInstanceManagerTests"],
144132
"configuration": "Release",
145133
"condition": {
146134
"type": "equals",
@@ -159,8 +147,7 @@
159147
},
160148
"execution": {
161149
"noTestsAction": "error",
162-
"stopOnFailure": false,
163-
"rerun-failed": true
150+
"stopOnFailure": false
164151
},
165152
"condition": {
166153
"type": "equals",
@@ -177,8 +164,7 @@
177164
},
178165
"execution": {
179166
"noTestsAction": "error",
180-
"stopOnFailure": false,
181-
"rerun-failed": true
167+
"stopOnFailure": false
182168
},
183169
"condition": {
184170
"type": "equals",
@@ -195,8 +181,7 @@
195181
},
196182
"execution": {
197183
"noTestsAction": "error",
198-
"stopOnFailure": false,
199-
"rerun-failed": true
184+
"stopOnFailure": false
200185
},
201186
"condition": {
202187
"type": "equals",

cmake/config.cmake.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
include("${CMAKE_CURRENT_LIST_DIR}/@PROJECT_NAME@Targets.cmake")
44
include(CMakeFindDependencyMacro)
55

6-
find_dependency(Qt6 REQUIRED COMPONENTS Core Widgets Svg)
6+
find_dependency(Qt6 REQUIRED COMPONENTS Core Network)
77

88
check_required_components(@PROJECT_NAME@)

src/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ install(DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/include/"
8888

8989
install(EXPORT "${PROJECT_NAME}Targets"
9090
FILE "${PROJECT_NAME}Targets.cmake"
91-
NAMESPACE ${PROJECT_NAME}::
91+
NAMESPACE ${PROJECT_NAMESPACE}::
9292
DESTINATION "${CMAKE_INSTALL_LIBDIR}/cmake/${PROJECT_NAME}"
9393
)
9494

@@ -100,5 +100,5 @@ install(FILES
100100

101101
export(EXPORT "${PROJECT_NAME}Targets"
102102
FILE "${CMAKE_BINARY_DIR}/cmake/${PROJECT_NAME}Targets.cmake"
103-
NAMESPACE ${PROJECT_NAME}::
103+
NAMESPACE ${PROJECT_NAMESPACE}::
104104
)

0 commit comments

Comments
 (0)