Replies: 2 comments 3 replies
-
I agree with the approach, but as these hashes are different in size, how are you going to accommodate new algorithms that are larger than the current ones in the future? |
Beta Was this translation helpful? Give feedback.
3 replies
-
Implemented in a935cd4 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Instead, use
fingerprint
object, which is more flexible and allows to add new algorithms.The issue with
md5
,sha1
, andsha2
attributes is that the algorithm name is used as an attribute name. Adding a new algorithm requires defining a new attribute.Beta Was this translation helpful? Give feedback.
All reactions