Runtime: Implement float primitives for 4.13 (#1113)

* Runtime: add float primitives
* Add tests for float operations
* Stop using polyfills for well-support float functions

The fma implementation is taken from https://gist.github.com/Yaffle/fb47de4c18b63147699e0b621f1031f7
The tests were taken directly from the ocaml testsuite and modified to
be expect-tests.

Co-authored-by: Philip White <[email protected]>
Co-authored-by: Hugo Heuzard <[email protected]>

Author: 3 people

CHANGES.md

@@ -4,6 +4,7 @@
 * Lib: add offsetX and offsetY to Dom_html.mouseEvent
 * Lib: add innerText property for Dom_html
 * Runtime: add dummy implementation for many dummy primitives
+* Runtime: add runtime for new float operation in 4.13 #1113 (by pmwhite)
 
 ## Misc
 * manual/rev_bindings.wiki: fix compilation error

compiler/tests-jsoo-floats/dune

@@ -0,0 +1,4 @@
+(library
+ (name jsoo_floats_testsuite)
+ (inline_tests (modes js))
+ (preprocess (pps ppx_expect)))

compiler/tests-jsoo-floats/test_floats.ml

@@ -0,0 +1,177 @@
+(* Js_of_ocaml compiler
+ * http://www.ocsigen.org/js_of_ocaml/
+ * Copyright (C) 2019 Hugo Heuzard
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, with linking exception;
+ * either version 2.1 of the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+ *)
+
+(* TODO: These float tests were put in their own library because they depend on
+ * primitives that aren't implemented in native OCaml. Once OCaml 4.13 gets
+ * released, they can be moved back into the tests-jsoo directory.
+ *)
+
+let%expect_test _ =
+  (* copied from https://github.com/ocaml/ocaml/pull/1794 *)
+  let z =
+    let x = -0. and y = 0. in
+    if mod_float x 1. >= 0. then x else if false then x else y
+  in
+  Printf.printf "%g\n" (1. /. z);
+  [%expect {|-inf|}]
+
+module Float = struct
+  include Float
+
+  external acosh : float -> float = "caml_acosh_float"
+
+  external asinh : float -> float = "caml_asinh_float"
+
+  external atanh : float -> float = "caml_atanh_float"
+
+  external erf : float -> float = "caml_erf_float"
+
+  external erfc : float -> float = "caml_erfc_float"
+
+  external cbrt : float -> float = "caml_cbrt_float"
+
+  external exp2 : float -> float = "caml_exp2_float"
+
+  external log2 : float -> float = "caml_log2_float"
+end
+
+let print f =
+  match Float.classify_float f with
+  | FP_nan -> print_endline "nan"
+  | _ -> Printf.printf "%f\n" f
+
+let%expect_test "acosh" =
+  let p x = print (Float.acosh x) in
+  p (-1.0);
+  [%expect {| nan |}];
+  p 0.0;
+  [%expect {| nan |}];
+  p 0.5;
+  [%expect {| nan |}];
+  p 1.0;
+  [%expect {| 0.000000 |}];
+  p 2.0;
+  [%expect {| 1.316958 |}]
+
+let%expect_test "asinh" =
+  let p x = print (Float.asinh x) in
+  p 1.0;
+  [%expect {| 0.881374 |}];
+  p 0.0;
+  [%expect {| 0.000000 |}];
+  p (-1.0);
+  [%expect {| -0.881374 |}];
+  p 2.0;
+  [%expect {| 1.443635 |}]
+
+let%expect_test "atanh" =
+  let p x = print (Float.atanh x) in
+  p (-2.0);
+  [%expect {| nan |}];
+  p (-1.0);
+  [%expect {| -inf |}];
+  p 0.0;
+  [%expect {| 0.000000 |}];
+  p 0.5;
+  [%expect {| 0.549306 |}];
+  p 1.0;
+  [%expect {| inf |}]
+
+let%expect_test "erf" =
+  let p x = print (Float.erf x) in
+  p (-2.0);
+  [%expect {| -0.995322 |}];
+  p (-1.0);
+  [%expect {| -0.842701 |}];
+  p 0.0;
+  [%expect {| 0.000000 |}];
+  p 0.5;
+  [%expect {| 0.520500 |}];
+  p 1.0;
+  [%expect {| 0.842701 |}];
+  p 10.0;
+  [%expect {| 1.000000 |}]
+
+let%expect_test "erfc" =
+  let p x = print (Float.erfc x) in
+  p (-2.0);
+  [%expect {| 1.995322 |}];
+  p (-1.0);
+  [%expect {| 1.842701 |}];
+  p 0.0;
+  [%expect {| 1.000000 |}];
+  p 0.5;
+  [%expect {| 0.479500 |}];
+  p 1.0;
+  [%expect {| 0.157299 |}];
+  p 10.0;
+  [%expect {| 0.000000 |}]
+
+let%expect_test "cbrt" =
+  let p x = print (Float.cbrt x) in
+  p Float.nan;
+  [%expect {| nan |}];
+  p (-1.0);
+  [%expect {| -1.000000 |}];
+  p (-0.0);
+  [%expect {| -0.000000 |}];
+  p Float.neg_infinity;
+  [%expect {| -inf |}];
+  p 0.0;
+  [%expect {| 0.000000 |}];
+  p 1.0;
+  [%expect {| 1.000000 |}];
+  p Float.infinity;
+  [%expect {| inf |}];
+  p 2.0;
+  [%expect {| 1.259921 |}]
+
+let%expect_test "exp2" =
+  let p x = print (Float.exp2 x) in
+  p Float.nan;
+  [%expect {| nan |}];
+  p (-1.0);
+  [%expect {| 0.500000 |}];
+  p (-0.0);
+  [%expect {| 1.000000 |}];
+  p Float.neg_infinity;
+  [%expect {| 0.000000 |}];
+  p 0.0;
+  [%expect {| 1.000000 |}];
+  p 1.0;
+  [%expect {| 2.000000 |}];
+  p Float.infinity;
+  [%expect {| inf |}];
+  p 2.0;
+  [%expect {| 4.000000 |}]
+
+let%expect_test "log2" =
+  let p x = print (Float.log2 x) in
+  p 3.0;
+  [%expect {| 1.584963 |}];
+  p 2.0;
+  [%expect {| 1.000000 |}];
+  p 1.0;
+  [%expect {| 0.000000 |}];
+  p 0.0;
+  [%expect {| -inf |}];
+  p (-2.0);
+  [%expect {| nan |}];
+  p 1024.0;
+  [%expect {| 10.000000 |}]