Compiler: use Object.is for phys_equal

Author: hhugo

compiler/lib/generate.ml

@@ -1292,11 +1292,25 @@ let rec translate_expr ctx queue loc x e level : _ * J.statement_list =
         | Eq, [ x; y ] ->
             let (px, cx), queue = access_queue' ~ctx queue x in
             let (py, cy), queue = access_queue' ~ctx queue y in
-            bool (J.EBin (J.EqEqEq, cx, cy)), or_p px py, queue
+            ( bool
+                (J.call
+                   (J.dot (s_var "Object") (Utf8_string.of_string_exn "is"))
+                   [ cx; cy ]
+                   loc)
+            , or_p px py
+            , queue )
         | Neq, [ x; y ] ->
             let (px, cx), queue = access_queue' ~ctx queue x in
             let (py, cy), queue = access_queue' ~ctx queue y in
-            bool (J.EBin (J.NotEqEq, cx, cy)), or_p px py, queue
+            ( J.EBin
+                ( J.Minus
+                , one
+                , J.call
+                    (J.dot (s_var "Object") (Utf8_string.of_string_exn "is"))
+                    [ cx; cy ]
+                    loc )
+            , or_p px py
+            , queue )
         | IsInt, [ x ] ->
             let (px, cx), queue = access_queue' ~ctx queue x in
             bool (Mlvalue.is_immediate cx), px, queue

compiler/tests-jsoo/test_obj.ml

@@ -72,14 +72,7 @@ let%expect_test "dup" =
   |}]
 
 let%expect_test "sameness" =
-  (* FIXME: Jsoo returns the wrong opposite result for cases below.
-     Would be fixed by GH#1410 *)
-  let f x =
-    match Sys.backend_type with
-    | Other "js_of_ocaml" -> not x
-    | Other _ | Native | Bytecode -> x
-  in
-  print_bool (f (nan == nan));
+  print_bool (nan == nan);
   [%expect {| true |}];
-  print_bool (f (-0. == 0.));
+  print_bool (-0. == 0.);
   [%expect {| false |}]