Runtime: fix for target-env browser

Author: hhugo

compiler/tests-compiler/target_env.ml

@@ -61,3 +61,52 @@ let () =
     without node filesystem
     Sys.readdir ok
     empty root |}]
+
+module Jsoo = Js_of_ocaml_compiler
+
+class find_require r =
+  object
+    inherit Jsoo.Js_traverse.iter as super
+
+    method! expression e =
+      (match e with
+      | ECall (EVar (Jsoo.Javascript.S { name = Utf8 "require"; loc; _ }), _, args, _)
+        -> (
+          match args with
+          | [ Arg name ] -> (
+              match name with
+              | EStr (Utf8 name) -> r := (name, loc) :: !r
+              | _ -> r := ("<Unknown>", loc) :: !r)
+          | _ -> assert false)
+      | _ -> ());
+      super#expression e
+  end
+
+(* Check target-env=browser doesn't use 'require("node:...")' *)
+let%expect_test _ =
+  let loc_to_string = function
+    | Jsoo.Javascript.N -> "N"
+    | U -> "U"
+    | Pi pi -> Jsoo.Parse_info.to_string pi
+  in
+  let test flags =
+    let r = ref [] in
+    let o = new find_require r in
+    let p = compile_and_parse_whole_program ~flags "" in
+    o#program p;
+    List.iter (fun (name, loc) -> Printf.eprintf "%s: %s\n" (loc_to_string loc) name) !r
+  in
+  test [ "--linkall" ];
+  [%expect
+    {|
+    test.js:7688:15: node:tty
+    test.js:7502:25: node:child_process
+    test.js:7314:17: node:util
+    test.js:6355:15: node:fs
+    test.js:1163:20: node:fs
+    test.js:1143:20: node:fs
+    test.js:1097:34: node:fs
+    test.js:1001:17: node:fs
+    |}];
+  test [ "--linkall"; "--target-env=browser" ];
+  [%expect {| |}]

runtime/js/sys.js

@@ -384,6 +384,14 @@ function caml_sys_temp_dir_name(_unit) {
   }
 }
 
+//Provides: caml_sys_temp_dir_name
+//Requires: caml_string_of_jsstring
+//Version: >= 5.4
+//If: browser
+function caml_sys_temp_dir_name(_unit) {
+  return caml_string_of_jsstring("");
+}
+
 //Provides: caml_sys_convert_signal_number
 //Version: >= 5.4
 function caml_sys_convert_signal_number(signo) {

runtime/js/unix.js

@@ -228,6 +228,14 @@ function caml_strerror(errno) {
   }
 }
 
+//Provides: caml_strerror
+//Requires: unix_error
+//If: browser
+function caml_strerror(errno) {
+  const code = unix_error[errno];
+  code || ("Unknown error " + errno)
+}
+
 //Provides: unix_error_message
 //Alias: caml_unix_error_message
 //Requires: caml_strerror, caml_string_of_jsstring