Misc: drop support for OCaml < 4.13 (#1919)

* Misc: drop support for OCaml < 4.13

* smaller stdlib

* CHANGES

Author: hhugo

.github/workflows/build.yml

@@ -17,11 +17,6 @@ jobs:
         os:
           - ubuntu-latest
         ocaml-compiler:
-          - "4.08"
-          - "4.09"
-          - "4.10"
-          - "4.11"
-          - "4.12"
           - "4.13"
           - "5.0"
           - "5.1"

CHANGES.md

@@ -1,6 +1,7 @@
 # dev
 
 ## Features/Changes
+* Misc: drop support for OCaml 4.12 and bellow
 * Compiler: use a Wasm text files preprocessor (#1822)
 * Compiler: support for OCaml 4.14.3+trunk (#1844)
 * Runtime: use es6 class (#1840)

CONTRIBUTING.md

@@ -28,8 +28,4 @@ opam install odoc lwt_log yojson ocp-indent graphics higlo
 
 ### Running the tests
 
-Tests are maintained for a single version of the OCaml compiler (currently 4.13).
-
-Make sure to use the correct opam switch (e.g. `opam switch 4.13.1`).
-
 Run `make tests`.

compiler/bin-js_of_ocaml/check_runtime.ml

@@ -22,7 +22,7 @@ open Js_of_ocaml_compiler
 
 let group_by_snd l =
   l
-  |> List.sort_uniq ~compare:(fun (n1, l1) (n2, l2) ->
+  |> List.sort_uniq ~cmp:(fun (n1, l1) (n2, l2) ->
          match Poly.compare l1 l2 with
          | 0 -> String.compare n1 n2
          | c -> c)
@@ -49,8 +49,8 @@ let f (runtime_files, bytecode, target_env) =
   let runtime_files, builtin =
     List.partition_map runtime_files ~f:(fun name ->
         match Builtins.find name with
-        | Some t -> `Snd t
-        | None -> `Fst name)
+        | Some t -> Right t
+        | None -> Left name)
   in
   let builtin =
     if false then builtin else Js_of_ocaml_compiler_runtime_files.runtime @ builtin

compiler/bin-js_of_ocaml/compile.ml

@@ -102,7 +102,8 @@ let sourcemap_section_of_info
         | Some _ -> Filename.concat "/builtin" filename)
   in
   let ignore_list =
-    List.filter sources ~f:(fun filename -> String.is_prefix ~prefix:"/builtin/" filename)
+    List.filter sources ~f:(fun filename ->
+        String.starts_with ~prefix:"/builtin/" filename)
   in
   let offset, mappings = Source_map.Mappings.encode_with_offset mappings in
   let map =
@@ -207,8 +208,8 @@ let run
   let runtime_files, builtin =
     List.partition_map runtime_files ~f:(fun name ->
         match Builtins.find name with
-        | Some t -> `Snd t
-        | None -> `Fst name)
+        | Some t -> Right t
+        | None -> Left name)
   in
   let t1 = Timer.make () in
   let builtin =

compiler/bin-wasm_of_ocaml/compile.ml

@@ -315,8 +315,8 @@ let run
   let runtime_js_files, builtin =
     List.partition_map runtime_js_files ~f:(fun name ->
         match Builtins.find name with
-        | Some t -> `Snd t
-        | None -> `Fst name)
+        | Some t -> Right t
+        | None -> Left name)
   in
   let t1 = Timer.make () in
   let builtin = Js_of_ocaml_compiler_runtime_files.runtime @ builtin in

compiler/lib-runtime-files/gen/gen.ml

@@ -58,7 +58,7 @@ let () =
   match Array.to_list Sys.argv with
   | [] -> assert false
   | _ :: rest ->
-      let rest = List.sort_uniq ~compare:String.compare rest in
+      let rest = List.sort_uniq ~cmp:String.compare rest in
       let fragments =
         List.map rest ~f:(fun f -> f, Js_of_ocaml_compiler.Linker.Fragment.parse_file f)
       in

compiler/lib-runtime-files/js_of_ocaml_compiler_runtime_files.ml

@@ -34,7 +34,6 @@ let runtime =
     ; hash
     ; ieee_754
     ; int64
-    ; internalMod
     ; ints
     ; io
     ; jslib

compiler/lib-runtime-files/tests/all.ml

@@ -30,7 +30,6 @@ let%expect_test _ =
     +hash.js
     +ieee_754.js
     +int64.js
-    +internalMod.js
     +ints.js
     +io.js
     +jslib.js
@@ -51,7 +50,8 @@ let%expect_test _ =
     +toplevel.js
     +unix.js
     +weak.js
-    +zstd.js |}];
+    +zstd.js
+    |}];
   printl runtime;
   [%expect
     {|
@@ -73,7 +73,6 @@ let%expect_test _ =
     +hash.js
     +ieee_754.js
     +int64.js
-    +internalMod.js
     +ints.js
     +io.js
     +jslib.js
@@ -93,7 +92,8 @@ let%expect_test _ =
     +sys.js
     +unix.js
     +weak.js
-    +zstd.js |}];
+    +zstd.js
+    |}];
   printl extra;
   [%expect {|
     +dynlink.js

compiler/lib/build_path_prefix_map.ml

@@ -100,15 +100,15 @@ let decode_map str =
         | Ok str -> Some str
         | Error err -> raise (Shortcut err))
   in
-  let pairs = String.split_char ~sep:':' str in
+  let pairs = String.split_on_char ~sep:':' str in
   match List.map ~f:decode_or_empty pairs with
   | exception Shortcut err -> Error err
   | map -> Ok map
 
 let rewrite_opt prefix_map path =
   let is_prefix = function
     | None -> false
-    | Some { target = _; source } -> String.is_prefix path ~prefix:source
+    | Some { target = _; source } -> String.starts_with path ~prefix:source
   in
   match
     List.find