Skip to content

Commit c027ecd

Browse files
committed
Update tyxml_js.ml
1 parent c26d400 commit c027ecd

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

lib/tyxml/tyxml_js.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@ module Xml = struct
7878
let n = Js.string n in
7979
match att with
8080
| Attr a ->
81+
(* Note that once we have weak pointers working, we'll need to React.S.retain *)
8182
let _ : unit React.S.t = React.S.map (function
8283
| Some v -> ignore(e##setAttribute(n, v))
8384
| None -> ignore(e##removeAttribute(n))) a
@@ -192,6 +193,7 @@ module Util = struct
192193

193194
let update_children (dom : Dom.node Js.t) (nodes : Dom.node Js.t t) =
194195
removeChildren dom;
196+
(* Note that once we have weak pointers working, we'll need to React.S.retain *)
195197
let _s : unit React.S.t = fold (fun () msg -> merge_msg dom msg) nodes ()
196198
in ()
197199
end

0 commit comments

Comments
 (0)