fixed front tests

Author: philippestepniewski

backend/domain/ports/user_handler.py

@@ -19,7 +19,7 @@ def add_project_user(self, project_name: str, email: str, role: ProjectRole) ->
         pass
 
     @abstractmethod
-    def get_all_users(self) -> list[str]:
+    def get_all_users(self) -> list[dict]:
         pass
 
     @abstractmethod

backend/infrastructure/user_psql_db_adapter.py

@@ -229,13 +229,12 @@ def get_users_role_for_project(self, email, project_name):
             connection.close()
         return role
 
-    def get_all_users(self) -> list[str]:
+    def get_all_users(self) -> list[dict]:
         connection = self._get_connection()
         try:
             cursor = connection.cursor()
-            cursor.execute("SELECT email FROM users")
-            users = cursor.fetchall()
-            users = [user[0] for user in users]
+            cursor.execute("SELECT email, role FROM users ORDER BY email")
+            users = [{"email": row[0], "role": row[1]} for row in cursor.fetchall()]
         finally:
             connection.close()
         return users

frontend/index.html

@@ -51,6 +51,17 @@
             <span class="nav-kbd">⌘K</span>
           </a>
         </div>
+        <div class="nav-group" id="admin-nav-group" style="display:none">
+          <span class="nav-group-label">ADMIN</span>
+          <a class="nav-item" data-route="admin" href="#admin">
+            <svg width="15" height="15" viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round">
+              <path d="M17 21v-2a4 4 0 0 0-4-4H5a4 4 0 0 0-4 4v2"/>
+              <circle cx="9" cy="7" r="4"/>
+              <path d="M23 21v-2a4 4 0 0 0-3-3.87M16 3.13a4 4 0 0 1 0 7.75"/>
+            </svg>
+            Users
+          </a>
+        </div>
       </nav>
 
       <div class="sidebar-footer">
@@ -102,6 +113,7 @@
   <script src="js/pages/project-detail.js"></script>
   <script src="js/pages/governance.js"></script>
   <script src="js/pages/search.js"></script>
+  <script src="js/pages/admin.js"></script>
   <script src="js/app.js"></script>
 </body>
 </html>

frontend/js/api.js

@@ -66,8 +66,8 @@ const API = (() => {
     // ── Users ─────────────────────────────────────────────────
     users: {
       getAll: () => get('/users/get_all').then(r => r.users ?? r),
-      create: (email, password) =>
-        post(`/users/add?email=${enc(email)}&password=${enc(password)}&role=SIMPLE_USER`),
+      create: (email, password, role = 'SIMPLE_USER') =>
+        post(`/users/add?email=${enc(email)}&password=${enc(password)}&role=${enc(role)}`),
     },
 
     // ── Projects ──────────────────────────────────────────────

frontend/js/app.js

@@ -74,6 +74,12 @@ const App = (() => {
         SearchPage.render(container, currentParams);
         break;
 
+      case 'admin':
+        showSidebar();
+        updateNavActive('admin');
+        AdminPage.render(container);
+        break;
+
       default:
         if (Auth.isLoggedIn()) {
           navigateTo('projects');
@@ -106,6 +112,10 @@ const App = (() => {
       const emailEl  = document.getElementById('user-email');
       if (avatarEl) avatarEl.textContent = avatarChar;
       if (emailEl)  emailEl.textContent  = email;
+
+      // Show admin nav group only for ADMIN users
+      const adminGroup = document.getElementById('admin-nav-group');
+      if (adminGroup) adminGroup.style.display = user.role === 'ADMIN' ? '' : 'none';
     }
   }
 

frontend/js/pages/project-detail.js

@@ -233,19 +233,21 @@ const ProjectDetailPage = (() => {
     }
     area.dataset.open = 'true';
 
+    // Try to load the user list for autocomplete (admin only).
+    // Always fall back to a plain text input so non-admins can still add users.
     let allUsers = [];
     try { allUsers = await API.users.getAll(); } catch {}
 
-    const userOptions = allUsers.map(u => {
-      const email = u.email || u.Email || u;
-      return `<option value="${escHtml(email)}">${escHtml(email)}</option>`;
-    }).join('');
+    const hasUserList = allUsers.length > 0;
+    const emailField = hasUserList
+      ? `<select class="form-select" id="add-user-email" style="flex:2">
+           ${allUsers.map(u => { const e = u.email || u; return `<option value="${escHtml(e)}">${escHtml(e)}</option>`; }).join('')}
+         </select>`
+      : `<input class="form-input" id="add-user-email" type="email" placeholder="user@example.com" style="flex:2" autocomplete="off">`;
 
     area.innerHTML = `
-      <div class="row-form">
-        <select class="form-select" id="add-user-select" style="flex:2">
-          ${userOptions || '<option value="">No users available</option>'}
-        </select>
+      <div class="row-form" style="padding:10px 20px;border-bottom:1px solid var(--border-0)">
+        ${emailField}
         <select class="form-select" id="add-user-role" style="flex:1">
           ${ROLES.map(r => `<option value="${r}">${r}</option>`).join('')}
         </select>
@@ -259,9 +261,10 @@ const ProjectDetailPage = (() => {
     });
 
     document.getElementById('add-user-submit').addEventListener('click', async () => {
-      const email = document.getElementById('add-user-select').value;
-      const role  = document.getElementById('add-user-role').value;
-      if (!email) return;
+      const emailEl = document.getElementById('add-user-email');
+      const email   = (emailEl.value || '').trim();
+      const role    = document.getElementById('add-user-role').value;
+      if (!email) { Toast.error('Please enter a user email.'); return; }
       try {
         await API.projects.addUser(projectName, email, role);
         Toast.success(`${email} added as ${role}.`);