fixed tests

Author: philippestepniewski

.github/workflows/test.yml

@@ -263,10 +263,20 @@ jobs:
           kubectl patch configmap backend-config -n model-platform --type merge -p "{\"data\":{\"IMAGE_TAG\":\"${IMAGE_TAG}\"}}"
           make k8s-modelplatform IMAGE_TAG=${IMAGE_TAG}
 
-      - name: Wait for infrastructure to settle (3m)
+      - name: Wait for backend to be ready
         run: |
-          echo "Waitin 3 minutes for infrastructure to settle"
-          sleep 60
+          echo "Waiting for backend healthcheck at http://model-platform.com/api/health"
+          for i in $(seq 1 60); do
+            STATUS=$(curl -s -o /dev/null -w "%{http_code}" http://model-platform.com/api/health)
+            if [ "$STATUS" = "200" ]; then
+              echo "Backend is ready (HTTP 200)"
+              exit 0
+            fi
+            echo "Attempt $i/60 — HTTP $STATUS, retrying in 10s..."
+            sleep 10
+          done
+          echo "Backend did not become ready after 10 minutes"
+          exit 1
 
       - name: Run end-to-end tests
         run: |

tests/tests_end_to_end/test_from_project_creation_to_model_predict.py

@@ -62,7 +62,7 @@ def setup_and_teardown():
 def test_health_endpoint_responds():
     """Test that the platform health endpoint responds."""
     result = subprocess.run(
-        ["curl", "-s", "-o", "/dev/null", "-w", "%{http_code}", f"http://{MP_HOSTNAME}/health"],
+        ["curl", "-s", "-o", "/dev/null", "-w", "%{http_code}", f"http://{MP_HOSTNAME}/api/health"],
         capture_output=True,
         text=True,
     )
@@ -78,25 +78,22 @@ def test_project_creation():
 
 def test_mlflow_registry_responds():
     """Test that MLflow registry responds after project creation."""
-    # Wait for MLflow to be ready
-    time.sleep(60)
+    registry_url = f"http://{MP_HOSTNAME}/registry/{PROJECT_NAME}/"
+    timeout = time.time() + 300  # 5-minute timeout
+    while time.time() < timeout:
+        result = subprocess.run(
+            ["curl", "-s", "-o", "/dev/null", "-w", "%{http_code}", registry_url],
+            capture_output=True,
+            text=True,
+        )
+        if result.stdout == "200":
+            global _mlflow_ready
+            _mlflow_ready = True
+            return
+        print(f"[DEBUG] MLflow registry HTTP {result.stdout}, retrying in 10s...")
+        time.sleep(10)
 
-    result = subprocess.run(
-        [
-            "curl",
-            "-s",
-            "-o",
-            "/dev/null",
-            "-w",
-            "%{http_code}",
-            f"http://{MP_HOSTNAME}/registry/{PROJECT_NAME}/#/models",
-        ],
-        capture_output=True,
-        text=True,
-    )
-    assert result.stdout == "200", f"MLflow registry did not respond with 200: {result.stdout}"
-    global _mlflow_ready
-    _mlflow_ready = True
+    assert False, f"MLflow registry did not respond with 200 within 5 minutes"
 
 
 # Flag to track if MLflow is ready
@@ -228,7 +225,6 @@ def _dump_registry_status():
 
 def test_train_and_push_model_to_mlflow():
     """Test model training and push to MLflow."""
-    time.sleep(120)
     _skip_if_mlflow_not_ready()
     # Verify MLflow API is operational before pushing
     api_url = f"http://{MP_HOSTNAME}/registry/{PROJECT_NAME}/api/2.0/mlflow/experiments/search"
@@ -278,7 +274,6 @@ def test_deploy_model():
 def test_deployed_model_health_check():
     """Test that deployed model responds to health check."""
     _skip_if_mlflow_not_ready()
-    time.sleep(180)
     deployment_name = sanitize_ressource_name(f"{PROJECT_NAME}-{MODEL_NAME}-{MODEL_VERSION}-deployment")
 
     # Check pod status first for debugging

tests/tests_end_to_end/test_frontend_e2e.py

@@ -0,0 +1,85 @@
+# author: Octo Technology MLOps tribe
+import pytest
+from playwright.sync_api import Page, expect
+
+from tests.conftest import DEFAULT_TEST_USER, MP_HOSTNAME, is_minikube_running
+
+BASE_URL = f"http://{MP_HOSTNAME}"
+
+
+@pytest.fixture(scope="session", autouse=True)
+def require_minikube():
+    if not is_minikube_running():
+        pytest.skip("Minikube not running — skipping frontend e2e tests")
+
+
+@pytest.fixture
+def logged_in_page(page: Page) -> Page:
+    """Fixture : ouvre la SPA et se connecte avec les credentials de test."""
+    page.goto(BASE_URL)
+    page.fill("#signin-email", DEFAULT_TEST_USER["username"])
+    page.fill("#signin-password", DEFAULT_TEST_USER["password"])
+    page.click("#signin-btn")
+    page.wait_for_selector("#projects-grid, #projects-empty", timeout=10_000)
+    return page
+
+
+@pytest.mark.e2e
+class TestFrontendIsUp:
+    """La SPA est servie et redirige correctement."""
+
+    def test_frontend_serves_spa(self, page: Page):
+        response = page.goto(BASE_URL)
+        assert response.status == 200
+        expect(page.locator("#app")).to_be_attached()
+
+    def test_unauthenticated_redirected_to_login(self, page: Page):
+        page.goto(f"{BASE_URL}/#projects")
+        expect(page.locator("#signin-email")).to_be_visible(timeout=5_000)
+
+
+@pytest.mark.e2e
+class TestAuthentication:
+    """Login / logout fonctionnent."""
+
+    def test_login_form_renders(self, page: Page):
+        page.goto(BASE_URL)
+        expect(page.locator("#signin-email")).to_be_visible()
+        expect(page.locator("#signin-password")).to_be_visible()
+        expect(page.locator("#signin-btn")).to_be_visible()
+
+    def test_login_with_valid_credentials(self, page: Page):
+        page.goto(BASE_URL)
+        page.fill("#signin-email", DEFAULT_TEST_USER["username"])
+        page.fill("#signin-password", DEFAULT_TEST_USER["password"])
+        page.click("#signin-btn")
+        expect(page.locator("#projects-grid, #projects-empty")).to_be_visible(timeout=10_000)
+
+    def test_login_with_invalid_credentials_shows_error(self, page: Page):
+        page.goto(BASE_URL)
+        page.fill("#signin-email", "invalid@example.com")
+        page.fill("#signin-password", "wrong_password")
+        page.click("#signin-btn")
+        expect(page.locator("#signin-error")).to_be_visible(timeout=5_000)
+
+    def test_logout_redirects_to_login(self, logged_in_page: Page):
+        logged_in_page.click("#logout-btn")
+        expect(logged_in_page.locator("#signin-email")).to_be_visible(timeout=5_000)
+
+
+@pytest.mark.e2e
+class TestNavigation:
+    """Navigation de base dans la SPA."""
+
+    def test_projects_page_shows_content(self, logged_in_page: Page):
+        expect(logged_in_page.locator("#projects-grid, #projects-empty")).to_be_visible(timeout=10_000)
+
+    def test_governance_page_loads(self, logged_in_page: Page):
+        logged_in_page.click("[data-route='governance']")
+        expect(logged_in_page.locator("#gov-project-select")).to_be_visible(timeout=5_000)
+
+    def test_create_project_modal_opens(self, logged_in_page: Page):
+        logged_in_page.click("[data-route='projects']")
+        logged_in_page.wait_for_selector("#new-project-btn", timeout=5_000)
+        logged_in_page.click("#new-project-btn")
+        expect(logged_in_page.locator("#new-proj-name")).to_be_visible(timeout=5_000)