chore: clean test

Author: morlay

pkg/sqltype/time/timestamp.go

@@ -31,7 +31,7 @@ func init() {
 var (
 	outputLayout     = time.RFC3339
 	supportedLayouts = map[string]*time.Location{
-		time.RFC3339: nil,
+		time.RFC3339: CST,
 	}
 )
 
@@ -75,14 +75,12 @@ func (Timestamp) DataType(engine string) string {
 
 func ParseTimestampFromString(s string) (d Timestamp, err error) {
 	for layout, cst := range supportedLayouts {
-		// fallback
 		t, e := time.ParseInLocation(layout, s, cst)
 		if e == nil {
 			return Timestamp(t), nil
 		}
 		err = e
 	}
-
 	return
 }
 

pkg/sqltype/time/timestamp_test.go

@@ -40,7 +40,7 @@ func TestTimestamp(t *testing.T) {
 	})
 
 	b.Given("time string", func(b bdd.T) {
-		t0, _ := time.ParseInLocation(time.RFC3339, "2017-03-27T23:58:59+08:00", nil)
+		t0, _ := time.ParseInLocation(time.RFC3339, "2017-03-27T23:58:59+08:00", CST)
 		dt := Timestamp(t0)
 
 		b.Then("output RFC3339 string",
@@ -63,14 +63,14 @@ func TestTimestamp(t *testing.T) {
 
 				b.Then("success",
 					bdd.NoError(dt2.UnmarshalText(data)),
-					bdd.Equal(dt, dt2),
+					bdd.Equal(dt.Unix(), dt2.Unix()),
 				)
 			})
 		})
 	})
 
 	b.Given("time string for custom output layout", func(b bdd.T) {
-		t0, _ := time.ParseInLocation(time.RFC3339, "2017-03-27T23:58:59+08:00", nil)
+		t0, _ := time.ParseInLocation(time.RFC3339, "2017-03-27T23:58:59+08:00", CST)
 		dt := Timestamp(t0)
 
 		b.When("marshal text", func(b bdd.T) {