fix: handle pg 18 not_null suffix indexes

Author: morlay

.github/workflows/test.yaml

@@ -10,7 +10,7 @@ jobs:
     runs-on: ubuntu-latest
     services:
       postgres:
-        image: docker.io/library/postgres:16.4
+        image: docker.io/library/postgres:18
         env:
           POSTGRES_PASSWORD: ""
           POSTGRES_HOST_AUTH_METHOD: trust
@@ -23,10 +23,10 @@ jobs:
           --health-retries 5
 
     steps:
-      - uses: actions/checkout@v3
-      - uses: extractions/setup-just@v2
-      - uses: actions/setup-go@v5
+      - uses: actions/checkout@v5
+      - uses: extractions/setup-just@v4
+      - uses: actions/setup-go@v6
         with:
-          go-version: '^1.24'
+          go-version: '^1.25'
 
       - run: just test-race

hack/compose.yml

@@ -1,6 +1,6 @@
 services:
   postgres:
-    image: docker.io/library/postgres:16
+    image: docker.io/library/postgres:18
     environment:
       POSTGRES_PASSWORD: ""
       POSTGRES_HOST_AUTH_METHOD: trust

internal/sql/adapter/postgres/catalog.go

@@ -106,7 +106,12 @@ ORDER BY conrelid::regclass::text, contype DESC;
 		for _, idxSchema := range indexList {
 			t := cat.Table(idxSchema.TABLE_NAME)
 
-			t.(sqlbuilder.KeyCollectionManager).AddKey(idxSchema.ToKey(t))
+			key := idxSchema.ToKey(t)
+			if key == nil {
+				continue
+			}
+
+			t.(sqlbuilder.KeyCollectionManager).AddKey(key)
 		}
 	}
 
@@ -185,6 +190,13 @@ func (indexSchema) TableName() string {
 }
 
 func (idxSchema *indexSchema) ToKey(table sqlbuilder.Table) sqlbuilder.Key {
+	// ignore pg 18 not_null indexes
+	// https://www.enterprisedb.com/blog/changes-not-null-postgres-18?utm_source=chatgpt.com
+	// https://www.postgresql.org/docs/current/ddl-constraints.html#DDL-CONSTRAINTS-NOT-NULL
+	if strings.HasPrefix(idxSchema.INDEX_DEF, "NOT NULL ") {
+		return nil
+	}
+
 	isUnique := strings.Contains(idxSchema.INDEX_DEF, "UNIQUE")
 	method := ""
 	name := ""
@@ -197,9 +209,9 @@ func (idxSchema *indexSchema) ToKey(table sqlbuilder.Table) sqlbuilder.Key {
 		name = "PRIMARY"
 		colParts = idxSchema.INDEX_DEF[len("PRIMARY KEY"):]
 	} else {
+		// USING <method> (f_col_1,f_col_2)
 		name = strings.ToLower(idxSchema.INDEX_NAME[len(table.TableName())+1:])
 		method = strings.ToUpper(reUsing.FindString(idxSchema.INDEX_DEF)[6:])
-		// USING
 		colParts = strings.TrimSpace(reUsing.Split(idxSchema.INDEX_DEF, 2)[1])
 	}