fix: SqlPrinter should not panic

morlay · morlay · commit a868b6b7e1dd · 2025-09-09T15:23:48.000+08:00
diff --git a/internal/sql/loggingdriver/interpolate_params.go b/internal/sql/loggingdriver/interpolate_params.go
@@ -23,7 +23,7 @@ type SqlPrinter struct {
 func (p *SqlPrinter) String() string {
 	s, err := InterpolateParams(p.query, p.args, time.Local)
 	if err != nil {
-		panic(err)
+		return "invalid: " + err.Error()
 	}
 	return s
 }
@@ -34,7 +34,7 @@ func InterpolateParams(query string, args []driver.NamedValue, loc *time.Locatio
 	}
 
 	if len(args) >= 65535 {
-		return "", fmt.Errorf("too many args: %d", len(args))
+		return "", fmt.Errorf("too many args: %d, query: %s", len(args), query)
 	}
 
 	buf := make([]byte, 0)

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ type SqlPrinter struct {`
`23`	`23`	`func (p *SqlPrinter) String() string {`
`24`	`24`	`s, err := InterpolateParams(p.query, p.args, time.Local)`
`25`	`25`	`if err != nil {`
`26`		`- panic(err)`
	`26`	`+ return "invalid: " + err.Error()`
`27`	`27`	`}`
`28`	`28`	`return s`
`29`	`29`	`}`
`@@ -34,7 +34,7 @@ func InterpolateParams(query string, args []driver.NamedValue, loc *time.Locatio`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`if len(args) >= 65535 {`
`37`		`- return "", fmt.Errorf("too many args: %d", len(args))`
	`37`	`+ return "", fmt.Errorf("too many args: %d, query: %s", len(args), query)`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`buf := make([]byte, 0)`