fix(anyjson): when right prop not exists should as false when left prop is boolean value

Author: morlay

anyjson/op__diff.go

@@ -66,7 +66,8 @@ func (d *differ) diffObject(left *Object, right *Object) Valuer {
 	merged := &Object{}
 
 	for key, valuer := range left.KeyValues() {
-		if rightValue, ok := right.Get(key); ok {
+		rightValue, rightExists := right.Get(key)
+		if rightExists {
 			switch x := rightValue.(type) {
 			case *Array:
 				if leftValue, ok := valuer.(*Array); ok {
@@ -93,6 +94,15 @@ func (d *differ) diffObject(left *Object, right *Object) Valuer {
 		}
 
 		if _, ok := valuer.(*Null); !ok {
+			if !rightExists {
+				// when right value is not exists , and left prop is bool
+				// right as false
+				if _, ok := valuer.(*Boolean); ok {
+					merged.Set(key, BooleanOf(false))
+					continue
+				}
+			}
+
 			merged.Set(key, valuer)
 		}
 	}

anyjson/op__diff_test.go

@@ -10,10 +10,11 @@ import (
 func TestDiff(t *testing.T) {
 	t.Run("normal diff", func(t *testing.T) {
 		base := MustFromValue(Obj{
-			"int_changed":      1,
-			"str_not_changed":  "string",
-			"list_not_changed": List{"1", "2"},
-			"list_changed":     List{"2"},
+			"int_changed":                1,
+			"str_not_changed":            "string",
+			"list_not_changed":           List{"1", "2"},
+			"list_changed":               List{"2"},
+			"bool_not_exists_as_changed": true,
 		}).(*Object)
 
 		target := MustFromValue(Obj{
@@ -27,8 +28,9 @@ func TestDiff(t *testing.T) {
 		testingx.Expect(t, err, testingx.Be[error](nil))
 
 		testingx.Expect(t, diffed.Value(), testingx.Equal[any](Obj{
-			"int_changed":  2,
-			"list_changed": List{"1"},
+			"int_changed":                2,
+			"list_changed":               List{"1"},
+			"bool_not_exists_as_changed": false,
 		}))
 	})
 

anyjson/op__merge.go

@@ -55,7 +55,8 @@ func (m *merger) mergeObject(left *Object, right *Object) Valuer {
 	merged := &Object{}
 
 	for key, valuer := range left.KeyValues() {
-		if rightValue, ok := right.Get(key); ok {
+		rightValue, rightExists := right.Get(key)
+		if rightExists {
 			switch x := rightValue.(type) {
 			case *Array:
 				if leftValue, ok := valuer.(*Array); ok {
@@ -71,7 +72,7 @@ func (m *merger) mergeObject(left *Object, right *Object) Valuer {
 				}
 			case *Null:
 				if m.nullOp == NullAsRemover {
-					// don't merger null valuer
+					// don't merge null valuer
 					valuer = &Null{}
 					continue
 				}
@@ -81,8 +82,18 @@ func (m *merger) mergeObject(left *Object, right *Object) Valuer {
 		}
 
 		if _, ok := valuer.(*Null); !ok {
+			if !rightExists {
+				// when right value is not exists , and left prop is bool
+				// drop left value
+				if _, ok := valuer.(*Boolean); ok {
+					merged.Delete(key)
+					continue
+				}
+			}
+
 			merged.Set(key, valuer)
 		}
+
 	}
 
 	for key, value := range right.KeyValues() {

anyjson/op__merge_test.go

@@ -15,6 +15,7 @@ func TestMerge(t *testing.T) {
 			"arr": List{
 				"1", "2",
 			},
+			"boolRemoveWhenNotExists": true,
 		}).(*Object)
 
 		patch := MustFromValue(Obj{