Merge branch 'master' into minor-cleanup

Author: grokys

Octokit.GraphQL.Core.Generation.UnitTests/EntityGenerationTests.cs

@@ -19,7 +19,7 @@ public class EntityGenerationTests : TestBase
 
     public class Entity : QueryableValue<Entity>{1}
     {{
-        public Entity(Expression expression) : base(expression)
+        internal Entity(Expression expression) : base(expression)
         {{
         }}
 {0}
@@ -1538,7 +1538,7 @@ public void Generates_Doc_Comments_For_Class()
     /// </summary>
     public class Entity : QueryableValue<Entity>
     {
-        public Entity(Expression expression) : base(expression)
+        internal Entity(Expression expression) : base(expression)
         {
         }
 
@@ -1580,7 +1580,7 @@ public void Generates_Multi_Line_Doc_Comments_For_Class()
     /// </summary>
     public class Entity : QueryableValue<Entity>
     {
-        public Entity(Expression expression) : base(expression)
+        internal Entity(Expression expression) : base(expression)
         {
         }
 
@@ -1636,7 +1636,7 @@ public void Generates_Doc_Comments_For_Property()
         public void Generates_Doc_Comments_For_Property_With_XmlCharacters()
         {
             var expected = FormatMemberTemplate(@"/// <summary>
-        /// Testing if doc comments are generated &lt;http://localhost&gt;.
+        /// Testing if doc comments &amp; generated &lt;http://localhost&gt;.
         /// </summary>
         public Other Foo => this.CreateProperty(x => x.Foo, Test.Other.Create);");
 
@@ -1649,7 +1649,7 @@ public void Generates_Doc_Comments_For_Property_With_XmlCharacters()
                     new FieldModel
                     {
                         Name = "Foo",
-                        Description = "Testing if doc comments are generated <http://localhost>.",
+                        Description = "Testing if doc comments & generated <http://localhost>.",
                         Type = TypeModel.Object("Other")
                     },
                 }
@@ -1770,7 +1770,7 @@ public Entity() : base(null)
         {
         }
 
-        public Entity(Expression expression) : base(expression)
+        internal Entity(Expression expression) : base(expression)
         {
         }
 
@@ -1819,7 +1819,7 @@ public Mutation() : base(null)
         {
         }
 
-        public Mutation(Expression expression) : base(expression)
+        internal Mutation(Expression expression) : base(expression)
         {
         }
 
@@ -1888,7 +1888,7 @@ public void Adds_IPageInfo_Interface_To_PageInfo()
 
     public class PageInfo : QueryableValue<PageInfo>, IPageInfo
     {
-        public PageInfo(Expression expression) : base(expression)
+        internal PageInfo(Expression expression) : base(expression)
         {
         }
 

Octokit.GraphQL.Core.Generation.UnitTests/InterfaceGenerationTests.cs

@@ -34,7 +34,7 @@ namespace Test.Internal
 
     internal class StubIEntity : QueryableValue<StubIEntity>, IEntity
     {{
-        public StubIEntity(Expression expression) : base(expression)
+        internal StubIEntity(Expression expression) : base(expression)
         {{
         }}
 {1}
@@ -709,7 +709,7 @@ public void Generates_Doc_Comments_For_Class()
     /// </summary>
     public class Entity : QueryableValue<Entity>
     {
-        public Entity(Expression expression) : base(expression)
+        internal Entity(Expression expression) : base(expression)
         {
         }
 

Octokit.GraphQL.Core.Generation.UnitTests/UnionGenerationTests.cs

@@ -18,7 +18,7 @@ public class UnionGenerationTests : TestBase
 
     public class Union : QueryableValue<Union>, IUnion
     {{
-        public Union(Expression expression) : base(expression)
+        internal Union(Expression expression) : base(expression)
         {{
         }}
 

Octokit.GraphQL.Core.Generation/DocCommentGenerator.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Text;
+using System.Xml;
 
 namespace Octokit.GraphQL.Core.Generation
 {
@@ -20,7 +21,7 @@ public static void GenerateSummary(string summary, int indentation, StringBuilde
 
         private static void GenerateCommentBlock(string text, string indent, StringBuilder builder)
         {
-            text = text.Replace("<", "&lt;").Replace(">", "&gt;");
+            text = text.Replace("&", "&amp;").Replace("<", "&lt;").Replace(">", "&gt;");
 
             foreach (var line in text.Split('\r', '\n'))
             {

Octokit.GraphQL.Core.Generation/EntityGenerator.cs

@@ -31,7 +31,7 @@ public static string Generate(
 
     {GenerateDocComments(type, generateDocComments)}{modifiers}class {className} : QueryableValue<{className}>{GenerateImplementedInterfaces(type, pagingConnectionNodeType)}
     {{
-        public {className}(Expression expression) : base(expression)
+        internal {className}(Expression expression) : base(expression)
         {{
         }}{GenerateFields(type, generateDocComments, rootNamespace, entityNamespace, queryType, pagingConnectionNodeType != null)}
 
@@ -64,7 +64,7 @@ public static string GenerateRoot(TypeModel type, string rootNamespace, string e
         {{
         }}
 
-        public {className}(Expression expression) : base(expression)
+        internal {className}(Expression expression) : base(expression)
         {{
         }}{GenerateFields(type, true, rootNamespace, entityNamespace, queryType, false)}
 

Octokit.GraphQL.Core.Generation/UnionGenerator.cs

@@ -23,7 +23,7 @@ public static string Generate(
 
     {GenerateUnionDocComments(type)}public class {className} : QueryableValue<{className}>, IUnion
     {{
-        public {className}(Expression expression) : base(expression)
+        internal {className}(Expression expression) : base(expression)
         {{
         }}
 

Octokit.GraphQL/Model/AcceptTopicSuggestionPayload.cs

@@ -11,7 +11,7 @@ namespace Octokit.GraphQL.Model
     /// </summary>
     public class AcceptTopicSuggestionPayload : QueryableValue<AcceptTopicSuggestionPayload>
     {
-        public AcceptTopicSuggestionPayload(Expression expression) : base(expression)
+        internal AcceptTopicSuggestionPayload(Expression expression) : base(expression)
         {
         }
 

Octokit.GraphQL/Model/Actor.cs

@@ -46,7 +46,7 @@ namespace Octokit.GraphQL.Model.Internal
 
     internal class StubIActor : QueryableValue<StubIActor>, IActor
     {
-        public StubIActor(Expression expression) : base(expression)
+        internal StubIActor(Expression expression) : base(expression)
         {
         }
 

Octokit.GraphQL/Model/AddCommentPayload.cs

@@ -11,7 +11,7 @@ namespace Octokit.GraphQL.Model
     /// </summary>
     public class AddCommentPayload : QueryableValue<AddCommentPayload>
     {
-        public AddCommentPayload(Expression expression) : base(expression)
+        internal AddCommentPayload(Expression expression) : base(expression)
         {
         }
 

Octokit.GraphQL/Model/AddProjectCardPayload.cs

@@ -11,7 +11,7 @@ namespace Octokit.GraphQL.Model
     /// </summary>
     public class AddProjectCardPayload : QueryableValue<AddProjectCardPayload>
     {
-        public AddProjectCardPayload(Expression expression) : base(expression)
+        internal AddProjectCardPayload(Expression expression) : base(expression)
         {
         }