Skip to content

Commit 83a5706

Browse files
authored
[maint] Adds coverage for validating broken inner paging
Make Can_AutoPage_Issues_Comments show AllPages issue
2 parents c3ab0d0 + 7600ff1 commit 83a5706

File tree

1 file changed

+39
-2
lines changed

1 file changed

+39
-2
lines changed

Octokit.GraphQL.IntegrationTests/Queries/IssueTests.cs

Lines changed: 39 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,45 @@ public async Task Can_AutoPage_Issues_Comments()
184184
{
185185
var query = new Query()
186186
.Repository(owner: "octokit", name: "octokit.net")
187-
.Issues().AllPages()
187+
.Issues().AllPages(50)
188+
.Select(issue => new
189+
{
190+
issue.Id,
191+
Comments = issue.Comments(null, null, null, null, null).AllPages(10).Select(comment => comment.Body).ToList(),
192+
});
193+
194+
var result = (await Connection.Run(query)).ToList();
195+
196+
Assert.Contains(result, x => x.Comments.Count > 20);
197+
}
198+
199+
[IntegrationTest]
200+
public async Task Can_AutoPage_Issues_Comments_With_Subquery()
201+
{
202+
var query = new Query()
203+
.Repository(owner: "octokit", name: "octokit.net")
204+
.Issues().AllPages(50)
205+
.Select(issue => new
206+
{
207+
issue.Id,
208+
Comments = issue.Comments(null, null, null, null, null).AllPages(10).Select(comment => new
209+
{
210+
comment.Body,
211+
Reactions = comment.Reactions(null, null, null, null, null, null).AllPages().Select(r => r.Id).ToList()
212+
}).ToList(),
213+
});
214+
215+
var result = (await Connection.Run(query)).ToList();
216+
217+
Assert.Contains(result, x => x.Comments.Count > 20);
218+
}
219+
220+
[IntegrationTest]
221+
public async Task Can_AutoPage_Issues_With_Subquery()
222+
{
223+
var query = new Query()
224+
.Repository(owner: "octokit", name: "octokit.net")
225+
.Issues().AllPages(50)
188226
.Select(issue => new
189227
{
190228
issue.Id,
@@ -194,7 +232,6 @@ public async Task Can_AutoPage_Issues_Comments()
194232
var result = (await Connection.Run(query)).ToList();
195233

196234
Assert.True(result.Count > 100);
197-
Assert.Contains(result, x => x.Comments.Count > 100);
198235
}
199236

200237
class ActorModel

0 commit comments

Comments
 (0)