Merge branch 'code-generation-bugfix' into doc-comments-escape-xml-characters

Author: StanleyGoldman

Octokit.GraphQL.Core.Generation.UnitTests/EntityGenerationTests.cs

@@ -1055,7 +1055,7 @@ public void Generates_Method_For_List_Field_With_Nullable_Enum_List_Arg()
         [Fact]
         public void Generates_Method_For_String_Field()
         {
-            var expected = FormatMemberTemplate("public int? Foo(Arg<string>? bar = null) => null;");
+            var expected = FormatMemberTemplate("public int? Foo(Arg<string>? bar = null) => default;");
 
             var model = new TypeModel
             {
@@ -1087,7 +1087,7 @@ public void Generates_Method_For_String_Field()
         [Fact]
         public void Generates_Method_For_NonNull_String_Field()
         {
-            var expected = FormatMemberTemplate("public int? Foo(Arg<string> bar) => null;");
+            var expected = FormatMemberTemplate("public int? Foo(Arg<string> bar) => default;");
 
             var model = new TypeModel
             {
@@ -1119,7 +1119,7 @@ public void Generates_Method_For_NonNull_String_Field()
         [Fact]
         public void Generates_Method_For_Scalar_Field()
         {
-            var expected = FormatMemberTemplate("public int? Foo(Arg<int>? bar = null) => null;");
+            var expected = FormatMemberTemplate("public int? Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {
@@ -1151,7 +1151,7 @@ public void Generates_Method_For_Scalar_Field()
         [Fact]
         public void Generates_Method_For_Deprecated_WithoutReason_Scalar_Field()
         {
-            var expected = FormatMemberTemplate($@"[Obsolete(@""Old and unused"")]{Environment.NewLine}        public int? Foo(Arg<int>? bar = null) => null;");
+            var expected = FormatMemberTemplate($@"[Obsolete(@""Old and unused"")]{Environment.NewLine}        public int? Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {
@@ -1185,7 +1185,7 @@ public void Generates_Method_For_Deprecated_WithoutReason_Scalar_Field()
         [Fact]
         public void Generates_Method_For_Deprecated_Scalar_Field()
         {
-            var expected = FormatMemberTemplate($@"[Obsolete]{Environment.NewLine}        public int? Foo(Arg<int>? bar = null) => null;");
+            var expected = FormatMemberTemplate($@"[Obsolete]{Environment.NewLine}        public int? Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {
@@ -1218,7 +1218,7 @@ public void Generates_Method_For_Deprecated_Scalar_Field()
         [Fact]
         public void Generates_Method_For_NonNull_Scalar_Field()
         {
-            var expected = FormatMemberTemplate("public int Foo(Arg<int>? bar = null) => null;");
+            var expected = FormatMemberTemplate("public int Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {
@@ -1250,7 +1250,7 @@ public void Generates_Method_For_NonNull_Scalar_Field()
         [Fact]
         public void Generates_Method_For_ID_Field()
         {
-            var expected = FormatMemberTemplate("public ID? Foo(Arg<int>? bar = null) => null;");
+            var expected = FormatMemberTemplate("public ID? Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {
@@ -1282,7 +1282,7 @@ public void Generates_Method_For_ID_Field()
         [Fact]
         public void Generates_Method_For_NonNull_ID_Field()
         {
-            var expected = FormatMemberTemplate("public ID Foo(Arg<int>? bar = null) => null;");
+            var expected = FormatMemberTemplate("public ID Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {

Octokit.GraphQL.Core.Generation.UnitTests/InterfaceGenerationTests.cs

@@ -512,7 +512,7 @@ public void Generates_Method_For_Scalar()
         {
             var expected = FormatMemberTemplate(
                 "int? Foo(Arg<int>? bar = null);",
-                "public int? Foo(Arg<int>? bar = null) => null;");
+                "public int? Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {
@@ -546,7 +546,7 @@ public void Generates_Method_For_NonNull_Scalar()
         {
             var expected = FormatMemberTemplate(
                 "int Foo(Arg<int>? bar = null);",
-                "public int Foo(Arg<int>? bar = null) => null;");
+                "public int Foo(Arg<int>? bar = null) => default;");
 
             var model = new TypeModel
             {

Octokit.GraphQL.Core.Generation/EntityGenerator.cs

@@ -229,7 +229,7 @@ private static string GenerateScalarMethod(FieldModel field, TypeModel type)
 
             GenerateArguments(field, out string arguments, out string parameters);
 
-            return $"{obsoleteAttribute}        public {csharpType} {name}({arguments}) => null;";
+            return $"{obsoleteAttribute}        public {csharpType} {name}({arguments}) => default;";
         }
 
         private static string GenerateObjectMethod(FieldModel field, TypeModel type, string entityNamespace)

Octokit.GraphQL/Model/Actor.cs

@@ -50,7 +50,7 @@ public StubIActor(Expression expression) : base(expression)
         {
         }
 
-        public string AvatarUrl(Arg<int>? size = null) => null;
+        public string AvatarUrl(Arg<int>? size = null) => default;
 
         public string Login { get; }
 

Octokit.GraphQL/Model/AddProjectCardPayload.cs

@@ -31,7 +31,7 @@ public AddProjectCardPayload(Expression expression) : base(expression)
         /// <summary>
         /// The ProjectColumn
         /// **Upcoming Change on 2019-01-01 UTC**
-        /// **Description:** Type for `projectColumn` will change from `Project!` to `Project`.
+        /// **Description:** Type for `projectColumn` will change from `Project!` to `ProjectColumn`.
         /// **Reason:** In preparation for an upcoming change to the way we report mutation errors, non-nullable payload fields are becoming nullable.
         /// </summary>
         public Project ProjectColumn => this.CreateProperty(x => x.ProjectColumn, Octokit.GraphQL.Model.Project.Create);

Octokit.GraphQL/Model/App.cs

@@ -41,7 +41,7 @@ public App(Expression expression) : base(expression)
         /// A URL pointing to the app's logo.
         /// </summary>
         /// <param name="size">The size of the resulting image.</param>
-        public string LogoUrl(Arg<int>? size = null) => null;
+        public string LogoUrl(Arg<int>? size = null) => default;
 
         /// <summary>
         /// The name of the app.

Octokit.GraphQL/Model/Bot.cs

@@ -19,7 +19,7 @@ public Bot(Expression expression) : base(expression)
         /// A URL pointing to the GitHub App's public avatar.
         /// </summary>
         /// <param name="size">The size of the resulting square image.</param>
-        public string AvatarUrl(Arg<int>? size = null) => null;
+        public string AvatarUrl(Arg<int>? size = null) => default;
 
         /// <summary>
         /// Identifies the date and time when the object was created.

Octokit.GraphQL/Model/CommentCannotUpdateReason.cs

@@ -40,5 +40,11 @@ public enum CommentCannotUpdateReason
         /// </summary>
         [EnumMember(Value = "VERIFIED_EMAIL_REQUIRED")]
         VerifiedEmailRequired,
+
+        /// <summary>
+        /// You cannot update this comment
+        /// </summary>
+        [EnumMember(Value = "DENIED")]
+        Denied,
     }
 }

Octokit.GraphQL/Model/CommitComment.cs

@@ -72,11 +72,21 @@ public CommitComment(Expression expression) : base(expression)
         /// </summary>
         public bool IncludesCreatedEdit { get; }
 
+        /// <summary>
+        /// Returns whether or not a comment has been minimized.
+        /// </summary>
+        public bool IsMinimized { get; }
+
         /// <summary>
         /// The moment the editor made the last edit
         /// </summary>
         public DateTimeOffset? LastEditedAt { get; }
 
+        /// <summary>
+        /// Returns why the comment was minimized.
+        /// </summary>
+        public string MinimizedReason { get; }
+
         /// <summary>
         /// Identifies the file path associated with the comment.
         /// </summary>
@@ -142,6 +152,11 @@ public CommitComment(Expression expression) : base(expression)
         /// </summary>
         public bool ViewerCanDelete { get; }
 
+        /// <summary>
+        /// Check if the current viewer can minimize this object.
+        /// </summary>
+        public bool ViewerCanMinimize { get; }
+
         /// <summary>
         /// Can user react to this subject
         /// </summary>

Octokit.GraphQL/Model/CommitHistoryConnection.cs

@@ -15,6 +15,9 @@ public CommitHistoryConnection(Expression expression) : base(expression)
         {
         }
 
+        /// <summary>
+        /// A list of edges.
+        /// </summary>
         public IQueryableList<CommitEdge> Edges => this.CreateProperty(x => x.Edges);
 
         /// <summary>