Merge pull request #236 from octokit/fixes/integration-tests

Update integration tests

Author: jcansdale

.github/workflows/integration-tests.yml

@@ -0,0 +1,36 @@
+name: Integration tests
+
+on:
+  push:
+
+  # Runs at 00:00 UTC every day
+  schedule:
+    - cron: '0 */24 * * *'  
+
+  # Runs when repository is starred
+  watch:
+    types: [started]  
+
+env:
+  config: Release
+
+jobs:
+  integration-tests:
+    runs-on: windows-latest
+
+    steps:
+    - uses: actions/checkout@v2
+
+    - name: Setup .NET Core
+      uses: actions/setup-dotnet@v1
+      with:
+        dotnet-version: 3.1.101
+
+    - name: Build using .NET Core
+      run: dotnet build Octokit.GraphQL.sln -c ${{ env.config }}
+
+    - name: Run integration tests
+      run: dotnet test -c ${{ env.config }} --no-build /p:CollectCoverage=true /p:CoverletOutputFormat=opencover /p:Exclude="[Octokit.GraphQL]Octokit.GraphQL.*" .\Octokit.GraphQL.IntegrationTests\Octokit.GraphQL.IntegrationTests.csproj
+      env:
+        OCTOKIT_GQL_OAUTHTOKEN: "${{ secrets.OCTOKIT_GQL_OAUTHTOKEN }}"
+        OCTOKIT_GQL_GITHUBUSERNAME: "${{ secrets.OCTOKIT_GQL_GITHUBUSERNAME }}"

Octokit.GraphQL.IntegrationTests/Queries/ErrorTests.cs

@@ -41,8 +41,10 @@ public async Task Should_Throw_Correct_Error_For_Name_Resolution_Failure()
         [IntegrationTest]
         public async Task Should_Throw_Correct_Error_For_Invalid_Repository_Name()
         {
+            var owner = "octokit";
+            var name = "bad_repository";
             var query = new Query()
-                .Repository(owner: "octokit", name: "bad_repository")
+                .Repository(owner: owner, name: name)
                 .Issues(first: 3)
                 .Nodes
                 .Select(i => new
@@ -52,7 +54,7 @@ public async Task Should_Throw_Correct_Error_For_Invalid_Repository_Name()
                 });
 
             var ex = await Assert.ThrowsAnyAsync<ResponseDeserializerException>(async () => await Connection.Run(query));
-            Assert.Equal("Could not resolve to a Repository with the name 'bad_repository'.", ex.Message);
+            Assert.Equal($"Could not resolve to a Repository with the name '{owner}/{name}'.", ex.Message);
             Assert.Equal(1, ex.Line);
             Assert.Equal(7, ex.Column);
         }

Octokit.GraphQL.IntegrationTests/Queries/PullRequestTests.cs

@@ -138,11 +138,22 @@ public async Task Can_Use_Conditional_In_BaseRef_Query()
             var query = new Query()
                 .Repository(owner: "octokit", name: "octokit.net")
                 .PullRequest(number: 1)
-                .Select(pr => pr.BaseRef != null ? pr.BaseRef.Name : null);
+                .Select(pr => new
+                {
+                    BaseRefName = pr.BaseRef != null ? pr.BaseRef.Name : null,
+                    BaseRefNotNull = pr.BaseRef != null
+                });
 
             var result = await Connection.Run(query);
 
-            Assert.Equal("master", result);
+            if (result.BaseRefNotNull)
+            {
+                Assert.Equal("main", result.BaseRefName);
+            }
+            else
+            {
+                Assert.Null(result.BaseRefName);
+            }
         }
 
         [IntegrationTest]
@@ -151,11 +162,22 @@ public async Task Can_Use_Conditional_When_Selecting_Base_Repository_Owner()
             var query = new Query()
                 .Repository(owner: "octokit", name: "octokit.net")
                 .PullRequest(number: 1)
-                .Select(pr => pr.BaseRef != null ? pr.BaseRef.Repository.Owner.Login : null);
+                .Select(pr => new
+                {
+                    Owner = pr.BaseRef != null ? pr.BaseRef.Repository.Owner.Login : null,
+                    BaseRefNotNull = pr.BaseRef != null
+                });
 
             var result = await Connection.Run(query);
 
-            Assert.Equal("octokit", result);
+            if (result.BaseRefNotNull)
+            {
+                Assert.Equal("octokit", result.Owner);
+            }
+            else
+            {
+                Assert.Null(result.Owner);
+            }
         }
 
         [IntegrationTest]

Octokit.GraphQL.IntegrationTests/Queries/RepositoryTests.cs

@@ -285,8 +285,8 @@ public async Task Query_Organization_Repositories_Select_Multiple_Object_Fragmen
                 });
 
             var testModelObject = await Connection.Run(query);
-            Assert.Equal("bkeepers", testModelObject.Member.StringField1);
-            Assert.Equal("bkeepers", testModelObject.MentionableUser.StringField1);
+            Assert.Equal("alanjrogers", testModelObject.Member.StringField1);
+            Assert.Equal("anaisbetts", testModelObject.MentionableUser.StringField1);
         }
 
         [IntegrationTest]

Octokit.GraphQL.IntegrationTests/Queries/ViewerTests.cs

@@ -53,8 +53,8 @@ public async Task Viewer_By_GraphyQL_Matches_Api()
             Assert.NotNull(graphqlUser);
 
             Assert.Equal(apiUser.AvatarUrl, graphqlUser.AvatarUrl);
-            Assert.Equal(apiUser.Bio ?? string.Empty, graphqlUser.Bio);
-            Assert.Equal(apiUser.Company ?? string.Empty, graphqlUser.Company);
+            Assert.Equal(apiUser.Bio, graphqlUser.Bio);
+            Assert.Equal(apiUser.Company, graphqlUser.Company);
 
             Assert.Equal(apiUser.CreatedAt.ToUniversalTime(), graphqlUser.CreatedAt.ToUniversalTime());