Skip to content

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Aug 18, 2023

  • Update test projects from .NET Core 3.1 (out of support) to .NET 6 (LTS)
  • Remove <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" /> (see Test projects end up with this GUID microsoft/vstest#472 (comment))
  • Remove <LangVersion>7.2</LangVersion> on test projects
  • Fix Run_Specifies_Cancellation_Token which (rightfully) throws when running on .NET 6

@kfcampbell
Copy link
Member

I'm interested in picking this up, as I'm looking at #312 but also want to update other aspects of the library. To avoid stomping on your branch/fork any further, I'll create a separate PR.

@0x5bfa
Copy link
Contributor

0x5bfa commented Sep 19, 2024

@Lamparter i think we've already worked this in our PR right?

@Lamparter
Copy link
Contributor

@Lamparter i think we've already worked this in our PR right?

Yes I think so. I definitely did do 1st (obviously) and I remember fixing the 4th task also. But not sure whether or not I implemented 2nd and 3rd.

  • Update test projects from .NET Core 3.1 (out of support) to .NET 6 (LTS)
  • Remove <Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" /> (see Test projects end up with this GUID microsoft/vstest#472 (comment))
  • Remove <LangVersion>7.2</LangVersion> on test projects
  • Fix Run_Specifies_Cancellation_Token which (rightfully) throws when running on .NET 6

@0x5bfa
Copy link
Contributor

0x5bfa commented Nov 8, 2024

#321 supersedes this PR, @Lamparter we seem to haven't implemented the 4th and sounds like we should separate.

@Lamparter
Copy link
Contributor

Separate?

@0x5bfa
Copy link
Contributor

0x5bfa commented Nov 8, 2024

Instead of including that change in #321

@Lamparter
Copy link
Contributor

Where would we include that change instead?

@0x5bfa
Copy link
Contributor

0x5bfa commented Nov 8, 2024

A new PR or here (with other changes reverted as superseded by our PR).

@Lamparter
Copy link
Contributor

This isn't our pr though. I think it's best to just leave in one pr.

@0xced 0xced force-pushed the cleanup-projects branch from da04bbe to e68d707 Compare May 14, 2025 16:36
* Update test projects from .NET Core 3.1 (out of support) to .NET 8 (LTS)
* Remove `<Service Include="{82a7f48d-3b50-4b1e-b82e-3ada8210c358}" />`  (see microsoft/vstest#472 (comment))
* Remove `<LangVersion>7.2</LangVersion>` on test projects
* Fix `Run_Specifies_Cancellation_Token` which (rightfully) throws when running on .NET 8
* Fix `Run_Throws_If_Query_Is_Null` which must be async
@0xced 0xced force-pushed the cleanup-projects branch from e68d707 to c5bb050 Compare May 14, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🛑 Blocked/Awaiting Response
Development

Successfully merging this pull request may close these issues.

4 participants